Maniphest T205956

HTMLInfoField.php: 'default' must be a FieldLayout or subclass when using 'rawrow'
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nikerabbit
	Oct 2 2018, 7:15 AM

Description

/wiki/Special:Preferences   Exception from line 86 of /srv/mediawiki/tags/2018-10-02_06:46:44/includes/htmlform/fields/HTMLInfoField.php: 'default' must be a FieldLayout or subclass when using 'rawrow'
#0 /srv/mediawiki/tags/2018-10-02_06:46:44/includes/htmlform/HTMLForm.php(1672): HTMLInfoField->getOOUI(string)
#1 /srv/mediawiki/tags/2018-10-02_06:46:44/includes/htmlform/HTMLForm.php(1692): HTMLForm->displaySection(array, string, string, boolean)
#2 /srv/mediawiki/tags/2018-10-02_06:46:44/includes/specials/forms/PreferencesFormOOUI.php(217): HTMLForm->displaySection(array, string, string)
#3 /srv/mediawiki/tags/2018-10-02_06:46:44/includes/htmlform/HTMLForm.php(1044): PreferencesFormOOUI->getBody()
#4 /srv/mediawiki/tags/2018-10-02_06:46:44/includes/htmlform/HTMLForm.php(1023): HTMLForm->getHTML(boolean)
#5 /srv/mediawiki/tags/2018-10-02_06:46:44/includes/htmlform/HTMLForm.php(577): HTMLForm->displayForm(boolean)
#6 /srv/mediawiki/tags/2018-10-02_06:46:44/includes/specials/SpecialPreferences.php(159): HTMLForm->show()
#7 /srv/mediawiki/tags/2018-10-02_06:46:44/includes/specialpage/SpecialPage.php(569): SpecialPreferences->execute(NULL)
#8 /srv/mediawiki/tags/2018-10-02_06:46:44/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(NULL)
#9 /srv/mediawiki/tags/2018-10-02_06:46:44/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#10 /srv/mediawiki/tags/2018-10-02_06:46:44/includes/MediaWiki.php(868): MediaWiki->performRequest()
#11 /srv/mediawiki/tags/2018-10-02_06:46:44/includes/MediaWiki.php(525): MediaWiki->main()
#12 /srv/mediawiki/tags/2018-10-02_06:46:44/index.php(42): MediaWiki->run()
#13 {main}

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	HTMLInfoField: Undo breaking change, deprecate instead, add release notes	mediawiki/core	master	+7 -1

Customize query in gerrit

Related Objects

Mentioned In: T225683: Error in Preferences in debug mode
Mentioned Here: rMWe6eb87ae2028: HTMLInfoField: Support 'rawrow' in OOUI mode
T203202: Beta features tab lead message in Special:Preferences doesn't play nicely with OOUI

Event Timeline

Nikerabbit created this task.Oct 2 2018, 7:15 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2018, 7:15 AM

Nikerabbit added a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Oct 2 2018, 7:16 AM

Relevant commit to rMW: rMWe6eb87ae2028: HTMLInfoField: Support 'rawrow' in OOUI mode.
Relevant task: T203202: Beta features tab lead message in Special:Preferences doesn't play nicely with OOUI

Some further debugging points me to https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/MediaWiki/Hooks/GetPreferences.php#L45

For me this is UBN! because Special:Preferences cannot be accessed on translatewiki.net currently.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptOct 2 2018, 7:25 AM

I have reverted rMWe6eb87ae2028: HTMLInfoField: Support 'rawrow' in OOUI mode locally.

@Nikerabbit Can you put some var_dumps or something into that method to identify the preferences field (and the extension) that is causing the issue? It works fine for me locally and on Beta Wikipedia.

In T205956#4633505, @matmarex wrote:

@Nikerabbit Can you put some var_dumps or something into that method to identify the preferences field (and the extension) that is causing the issue? It works fine for me locally and on Beta Wikipedia.

Yes, did you see my comment above?

Oh, I didn't, duh.

I guess this is the same issue as T203202 and needs the same fix as https://gerrit.wikimedia.org/r/c/mediawiki/extensions/BetaFeatures/+/457504

No longer UBN! since I have a workaround.

Change 464062 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] HTMLInfoField: Undo breaking change, deprecate instead, add release notes

https://gerrit.wikimedia.org/r/464062

gerritbot added a project: Patch-For-Review.Oct 2 2018, 9:51 PM

@Nikerabbit I would appreciate if you could review. Thanks for reporting the issue!

Change 464062 merged by jenkins-bot:
[mediawiki/core@master] HTMLInfoField: Undo breaking change, deprecate instead, add release notes

https://gerrit.wikimedia.org/r/464062

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 11 2018, 1:00 AM

matmarex closed this task as Resolved.Oct 11 2018, 1:18 AM

matmarex claimed this task.

matmarex removed a project: Patch-For-Review.

Liuxinyu970226 unsubscribed.Oct 27 2018, 7:42 AM

matmarex mentioned this in T225683: Error in Preferences in debug mode.Jun 13 2019, 8:15 PM

Reedy merged a task: T225683: Error in Preferences in debug mode.Jun 13 2019, 8:23 PM