Page MenuHomePhabricator
Create Task
Maniphest T206200

Showcase a termbox placeholder in the mobile frontend of m.wikidata.org
Closed, ResolvedPublic13 Estimated Story Points
Actions

Assigned To
• Lea_WMDE
Authored By
• Jonas
Oct 4 2018, 9:22 AM
Tags
Referenced Files
F27094537: Bildschirmfoto von 2018-11-07 13-47-42.png
Nov 7 2018, 12:54 PM
F27094536: Bildschirmfoto von 2018-11-07 13-54-02.png
Nov 7 2018, 12:54 PM
Subscribers
Aklapper
gerritbot
Jakob_WMDE
• Jonas
• Lea_WMDE
• Matthias_Geisler_WMDE
• Pablo-WMDE

Description

We would like to create the technical basics for the termbox implementation.
Therefor we implement a termbox placeholder with the decided technologies.

  • Hidden behind feature flag
  • Below the title and watchlist there is a grey rectangle indicating where the termbox info will be.

Dev note:
This story will include introducing vue.js to the frontend for all termbox related things.
Ideally, the watchlist star and title stay out of it.

Details

SubjectRepoBranchLines +/-
Termbox: provide CSS without JS, toomediawiki/extensions/Wikibasemaster+21 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Jonas triaged this task as Medium priority.Oct 4 2018, 9:22 AM
• Jonas created this task.
• Pablo-WMDE renamed this task from Showcase a termbox placeholder in the mobile frontend of m.Wikidat.org to Showcase a termbox placeholder in the mobile frontend of m.wikidata.org.Oct 9 2018, 8:15 AM
Addshore moved this task from incoming to in progress on the Wikidata board.Oct 9 2018, 9:36 AM
Jakob_WMDE closed subtask T206514: Mirror the wikibase-termbox repo on Phabricator as Resolved.Oct 12 2018, 8:47 AM
Jakob_WMDE closed subtask T206523: Set up CI for Termbox as Resolved.Oct 12 2018, 5:15 PM
• Matthias_Geisler_WMDE subscribed.Oct 16 2018, 10:18 AM

Url to the ssr server: http://ssr-termbox.wmflabs.org/termbox

• Lea_WMDE added a project: Wikidata-Termbox-Iteration-2.Oct 17 2018, 9:10 AM
• Lea_WMDE changed the point value for this task from 8 to 13.Oct 17 2018, 9:14 AM
• Lea_WMDE added a project: Wikidata-Termbox-Iteration-3.Oct 31 2018, 9:50 AM
• Pablo-WMDE mentioned this in T208381: mediawiki - node SSR HTTP request follow-up [2*2h].Nov 1 2018, 9:33 AM
• Pablo-WMDE subscribed.EditedNov 1 2018, 4:20 PM

Random observations I'd like to discuss before we call this:

  • id="app" on the vue root element needs to change - in theory this is bigger than "termbox" as the actual termbox component is a (currently only) child of it. How about wikibase-vue-view for starters? I'm also tempted to leave the technology out of it but I think it's ok for it to be "special" for the moment. => id removed, the mount element is now called .wikibase-entitytermsview
  • data-server-rendered=true is very handy indeed to quickly tell if HTML was produced on the server side. Should we add another / remove this data attribute when (re)drawing on the client side?
  • apparently the CSS for .termbox-placeholder does not come into effect when looking at wikibase including the SSR result w/o JS, i.e. it's not a grey box. => find, fix

Bildschirmfoto von 2018-11-07 13-47-42.png (890×943 px, 149 KB)
Bildschirmfoto von 2018-11-07 13-54-02.png (890×943 px, 149 KB)

gerritbot subscribed.Nov 1 2018, 5:49 PM

Change 471050 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] Termbox: provide CSS withouth JS, too

https://gerrit.wikimedia.org/r/471050

gerritbot added a project: Patch-For-Review.Nov 1 2018, 5:49 PM
gerritbot added a comment.Nov 7 2018, 3:14 PM

Change 471050 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Termbox: provide CSS without JS, too

https://gerrit.wikimedia.org/r/471050

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 7 2018, 4:01 PM
Jakob_WMDE moved this task from To Do to Test (Product Review) on the Wikidata-Termbox-Iteration-3 board.Nov 9 2018, 10:12 AM
Jakob_WMDE closed subtask T206525: Node API for Termbox SSR as Resolved.Nov 9 2018, 10:26 AM
Jakob_WMDE closed subtask T206522: Create the termbox placeholder as Resolved.
Jakob_WMDE closed subtask T206518: Add wikibase-termbox to Wikibase as Resolved.
• Lea_WMDE added a subscriber: Jakob_WMDE.Nov 9 2018, 12:19 PM

Hi @Jakob_WMDE , can you tell me where I can test this? Thanks :)

Jakob_WMDE added a comment.Nov 9 2018, 1:55 PM

@Lea_WMDE Hi! We're working on getting it to beta! I'll try to remember to add a link once it's there.

Jakob_WMDE added a comment.Nov 9 2018, 2:38 PM

@Lea_WMDE https://wikidata.beta.wmflabs.org/w/index.php?title=Item:Q9&useformat=mobile 🎉

• Lea_WMDE closed this task as Resolved.Nov 12 2018, 9:35 AM
• Lea_WMDE claimed this task.
• Lea_WMDE moved this task from Test (Product Review) to Done on the Wikidata-Termbox-Iteration-3 board.

yay! What a beautiful grey rectangle!

Jakob_WMDE closed subtask T206863: Enable mobile-specific html to be rendered within Wikibase as Resolved.Nov 12 2018, 4:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits