Maniphest T206324

MonoBook master is failing eslint
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Oct 5 2018, 1:44 PM

Description

01:21:47 /workspace/src/skins/MonoBook/resources/mobile-echo.js
01:21:47   57:4  error  'mediaWiki' is not defined  no-undef
01:21:47 
01:21:47 /workspace/src/skins/MonoBook/resources/mobile.js
01:21:47   91:4  error  'mediaWiki' is not defined  no-undef

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php71-docker/675/consoleFull

Also reproduced locally.

Details

	Subject	Repo	Branch	Lines +/-
	Stop using mediaWiki and jQuery globals to fix eslint	mediawiki/skins/MonoBook	master	+4 -4

Customize query in gerrit

Event Timeline

Legoktm triaged this task as Unbreak Now! priority.Oct 5 2018, 1:44 PM

Legoktm created this task.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes, Aklapper. · View Herald TranscriptOct 5 2018, 1:44 PM

Possible broken by a core change - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/456068/

Change 465309 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/skins/MonoBook@master] Stop using mediaWiki and jQuery globals to fix eslint

https://gerrit.wikimedia.org/r/465309

gerritbot added a project: Patch-For-Review.Oct 9 2018, 4:25 AM

Change 465309 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Stop using mediaWiki and jQuery globals to fix eslint

https://gerrit.wikimedia.org/r/465309

matmarex closed this task as Resolved.Oct 9 2018, 10:58 AM

matmarex assigned this task to Legoktm.

matmarex removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 9 2018, 11:00 AM

Liuxinyu970226 unsubscribed.Oct 27 2018, 8:47 AM