Page MenuHomePhabricator

MonoBook master is failing eslint
Closed, ResolvedPublic

Description

01:21:47 /workspace/src/skins/MonoBook/resources/mobile-echo.js
01:21:47   57:4  error  'mediaWiki' is not defined  no-undef
01:21:47 
01:21:47 /workspace/src/skins/MonoBook/resources/mobile.js
01:21:47   91:4  error  'mediaWiki' is not defined  no-undef

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php71-docker/675/consoleFull

Also reproduced locally.

Event Timeline

Legoktm triaged this task as Unbreak Now! priority.Oct 5 2018, 1:44 PM
Legoktm created this task.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes, Aklapper. · View Herald TranscriptOct 5 2018, 1:44 PM

Change 465309 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/skins/MonoBook@master] Stop using mediaWiki and jQuery globals to fix eslint

https://gerrit.wikimedia.org/r/465309

Change 465309 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Stop using mediaWiki and jQuery globals to fix eslint

https://gerrit.wikimedia.org/r/465309

matmarex closed this task as Resolved.Oct 9 2018, 10:58 AM
matmarex assigned this task to Legoktm.
matmarex removed a project: Patch-For-Review.