Page MenuHomePhabricator
Create Task
Maniphest T206473

Opening the maps dialog causes a change in the maps node attributes
Closed, ResolvedPublic
Actions

Description

On clicking on a map to edit it, the dialog opens with the "Apply changes" action enabled, if the GeoJSON input is empty. It is then possible to click on "Apply changes" to close the dialog, and then click on "Save", even though no edit was made.

Details

SubjectRepoBranchLines +/-
Don't add body attribute to an extension node with an empty bodymediawiki/extensions/VisualEditormaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Oct 8 2018, 4:27 PM
gerritbot subscribed.Oct 8 2018, 4:41 PM

Change 465193 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/VisualEditor@master] Don't add body attribute to an extension node with an empty body

https://gerrit.wikimedia.org/r/465193

gerritbot added a project: Patch-For-Review.Oct 8 2018, 4:41 PM
Tchanders updated the task description. (Show Details)Oct 8 2018, 4:54 PM
matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.Oct 8 2018, 10:54 PM
gerritbot added a comment.Oct 8 2018, 11:16 PM

Change 465193 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Don't add body attribute to an extension node with an empty body

https://gerrit.wikimedia.org/r/465193

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 9 2018, 12:01 AM
Jdforrester-WMF edited projects, added Maps (Kartographer), VisualEditor-DataModel; removed Patch-For-Review.Oct 9 2018, 3:47 PM
Ryasmeen subscribed.Oct 10 2018, 12:01 AM
This comment was removed by Ryasmeen.
Ryasmeen added a project: Verified.Oct 10 2018, 12:01 AM
Aklapper changed the edit policy from "Custom Policy" to "All Users".Oct 10 2018, 6:37 AM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Oct 10 2018, 8:56 PM
• Deskana closed this task as Resolved.Oct 11 2018, 3:10 PM
• Deskana triaged this task as Low priority.
• Deskana added a project: Editing Q2 2018-19 mobile improvements.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 11 2018, 3:10 PM
matmarex mentioned this in T206000: Apply changes action is enabled on several dialogs before any changes are made.Nov 15 2018, 2:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL