Page MenuHomePhabricator

ParserFunctions/includes/ExprParser.php triggers warnings in PHP 7.3
Closed, ResolvedPublic

Description

km@km-pt:/srv/mediawiki/core$ php -l extensions/ParserFunctions/includes/ExprParser.php 
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in extensions/ParserFunctions/includes/ExprParser.php on line 242
No syntax errors detected in extensions/ParserFunctions/includes/ExprParser.php

Event Timeline

Legoktm created this task.Oct 15 2018, 6:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2018, 6:42 AM

Change 467306 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/extensions/ParserFunctions@master] Use "break" instead of "continue"

https://gerrit.wikimedia.org/r/467306

RazeSoldier triaged this task as Medium priority.

Change 467306 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@master] Use "break" instead of "continue" inside a switch

https://gerrit.wikimedia.org/r/467306

matmarex closed this task as Resolved.Oct 15 2018, 4:05 PM
matmarex removed a project: Patch-For-Review.

Change 467407 had a related patch set uploaded (by Paladox; owner: 星耀晨曦):
[mediawiki/extensions/ParserFunctions@REL1_31] Use "break" instead of "continue" inside a switch

https://gerrit.wikimedia.org/r/467407

Change 467407 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@REL1_31] Use "break" instead of "continue" inside a switch

https://gerrit.wikimedia.org/r/467407