Maniphest T206977

ExprParser.php triggers warnings in PHP 7.3
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Oct 15 2018, 6:42 AM

Description

km@km-pt:/srv/mediawiki/core$ php -l extensions/ParserFunctions/includes/ExprParser.php 
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in extensions/ParserFunctions/includes/ExprParser.php on line 242
No syntax errors detected in extensions/ParserFunctions/includes/ExprParser.php

Details

	Subject	Repo	Branch	Lines +/-
	Use "break" instead of "continue" inside a switch	mediawiki/extensions/ParserFunctions	REL1_31	+35 -35
	Use "break" instead of "continue" inside a switch	mediawiki/extensions/ParserFunctions	master	+35 -35

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Reedy	T206988 MediaWiki 1.31.x should be compatible with PHP 7.3
		Resolved		RazeSoldier	T206977 ParserFunctions/includes/ExprParser.php triggers warnings in PHP 7.3

Event Timeline

Legoktm created this task.Oct 15 2018, 6:42 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2018, 6:42 AM

Legoktm moved this task from Backlog to Bundled extensions/skins on the PHP 7.3 support board.Oct 15 2018, 7:02 AM

Change 467306 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/extensions/ParserFunctions@master] Use "break" instead of "continue"

https://gerrit.wikimedia.org/r/467306

gerritbot added a project: Patch-For-Review.Oct 15 2018, 10:44 AM

RazeSoldier claimed this task.Oct 15 2018, 10:49 AM

RazeSoldier triaged this task as Medium priority.

Change 467306 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@master] Use "break" instead of "continue" inside a switch

https://gerrit.wikimedia.org/r/467306

matmarex closed this task as Resolved.Oct 15 2018, 4:05 PM

matmarex removed a project: Patch-For-Review.

Change 467407 had a related patch set uploaded (by Paladox; owner: 星耀晨曦):
[mediawiki/extensions/ParserFunctions@REL1_31] Use "break" instead of "continue" inside a switch

https://gerrit.wikimedia.org/r/467407

gerritbot added a project: Patch-For-Review.Oct 15 2018, 4:06 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 15 2018, 5:01 PM

Change 467407 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@REL1_31] Use "break" instead of "continue" inside a switch

https://gerrit.wikimedia.org/r/467407

Legoktm added a parent task: T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.Oct 16 2018, 12:25 AM