Maniphest T207341

mobile.startup
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Overlay.js has already been migrated to webpack's control in T205593, but its associated tests proved to be challenging to migrate due to Overlay's use of mw.template.get and it's dependencies use of mw.template.get (Anchor.js, Button.js). It was thus decided to leave its test file as is, and migrate it in a future card (this one).

Acceptance criteria

Overlay.test.js is migrated to tests/node-qunit/mobile.startup and can be run from headless qunit
$testFiles[] = 'tests/qunit/mobile.startup/Overlay.test.js; line is removed from MobileFrontend.hooks.php
Global usages of jquery in Overlay.test.js are replaced with calls to util.js

Note: Adding additional test coverage is out of scope and will be added separately.

Sign off steps

Measure and record code coverage on the wiki page

Details

	Subject	Repo	Branch	Lines +/-
	Migrate Overlay.test.js to tests/node-qunit/mobile.startup	mediawiki/extensions/MobileFrontend	master	+91 -71

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T195478 [EPIC] Speed up unit test execution and increase code coverage
Resolved	Jdlrobson	T207341 Migrate Overlay.test.js to tests/node-qunit/mobile.startup

Event Timeline

• nray created this task.Oct 17 2018, 10:29 PM

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptOct 17 2018, 10:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• nray mentioned this in T205593: Webpack: Skins and Overlay management.Oct 17 2018, 10:32 PM

• nray updated the task description. (Show Details)

• nray updated the task description. (Show Details)Oct 17 2018, 10:34 PM

Jdlrobson added a parent task: T195478: [EPIC] Speed up unit test execution and increase code coverage.Oct 18 2018, 4:36 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Oct 18 2018, 5:00 PM

Jdlrobson moved this task from Needs Prioritization to Upcoming on the Web-Team-Backlog board.

Jdlrobson raised the priority of this task from Medium to High.Oct 18 2018, 5:02 PM

The file to port is https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/tests/qunit/mobile.startup/Overlay.test.js
Estimated by @nray @pmiazga, @Niedzielski and @Jdlrobson

Jdlrobson moved this task from Upcoming to Readers-Web-Kanbanana-Board-2018-19-Q2 on the Web-Team-Backlog board.Oct 23 2018, 4:54 PM

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.

• nray claimed this task.Oct 23 2018, 8:28 PM

• nray moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

Change 469450 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Migrate Overlay.test.js to tests/node-qunit/mobile.startup

https://gerrit.wikimedia.org/r/469450

gerritbot added a project: Patch-For-Review.Oct 24 2018, 3:43 PM

• nray moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 24 2018, 3:44 PM