Page MenuHomePhabricator

jqueryMsg error breaks Wikibase term editing
Closed, ResolvedPublic

Description

Item and property pages currently throw jQuery.Deferred exception: Cannot read property 'nodeType' of undefined TypeError: Cannot read property 'nodeType' of undefined in mediawiki.jqueryMsg.js#1380 which prevents label/description/alias editing.

Reproduce: click on "edit" next to the description https://wikidata.beta.wmflabs.org/wiki/Q6

A possible fix is up here: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/468349

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2018, 4:18 PM
Jakob_WMDE triaged this task as Unbreak Now! priority.Oct 18 2018, 4:19 PM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptOct 18 2018, 4:19 PM

Change 468349 had a related patch set uploaded (by Addshore; owner: Jakob):
[mediawiki/core@master] Fix jqueryMsg breaking when passed an undefined param

https://gerrit.wikimedia.org/r/468349

Change 468349 merged by jenkins-bot:
[mediawiki/core@master] Fix jqueryMsg breaking when passed an undefined param

https://gerrit.wikimedia.org/r/468349

matmarex closed this task as Resolved.Oct 18 2018, 6:03 PM
matmarex removed a project: Patch-For-Review.
matmarex added a subscriber: matmarex.

Sorry about that.

(I think per the documentation, you're not supposed to pass undefined/null there. But I don't think it is reasonable to throw an exception for it, especially if the undefined parameter is not even being used.)

Sorry about that.

(I think per the documentation, you're not supposed to pass undefined/null there. But I don't think it is reasonable to throw an exception for it, especially if the undefined parameter is not even being used.)

I created an investigation to figure out why / where this is happening within wikibase