Maniphest T207413

Forcing type Language on Skin::doEditSectionLink generates a warning on `MinervaNeue` and possibly other skins that override this method
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dmaza
	Oct 18 2018, 8:02 PM

Description

Forcing type Language on Skin::doEditSectionLink generates a warning on MinervaNeue and possibly other skins that override this method

This is the change:
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/447505

Here is the warning

Warning: Declaration of SkinMinerva::doEditSectionLink(Title $nt, $section, $tooltip = NULL, $lang = false) should be compatible with Skin::doEditSectionLink(Title $nt, $section, $tooltip, Language $lang) in /vagrant/mediawiki/skins/MinervaNeue/includes/skins/SkinMinerva.php on line

Details

	Subject	Repo	Branch	Lines +/-
	Force type Language for $lang of doEditSectionLink	mediawiki/skins/MinervaNeue	master	+2 -2

Customize query in gerrit

Event Timeline

dmaza created this task.Oct 18 2018, 8:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2018, 8:02 PM

I think https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/447502/ takes care of this. Ping @Fomafix @cscott for confirmation.

Jdlrobson added a project: Web-Team-Backlog.Oct 18 2018, 8:12 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

Change 447502 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/skins/MinervaNeue@master] Force type Language for $lang of doEditSectionLink

https://gerrit.wikimedia.org/r/447502

gerritbot added a project: Patch-For-Review.Oct 18 2018, 8:13 PM

Yes, https://gerrit.wikimedia.org/r/447502 removes this warning. I can reproduce this.

CCicalese_WMF removed a project: Platform Engineering.Oct 18 2018, 8:16 PM

In T207413#4678668, @Jdlrobson wrote:

I think https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/447502/ takes care of this. Ping @Fomafix @cscott for confirmation.

That fixes MinervaNeue. I'm not sure how to check if this happens in other skins

https://codesearch.wmflabs.org/search/?q=doEditSectionLink finds no other skins. There may by external skins.

Jdlrobson triaged this task as High priority.Oct 18 2018, 8:19 PM

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.

Change 447502 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Force type Language for $lang of doEditSectionLink

https://gerrit.wikimedia.org/r/447502

Jdlrobson moved this task from To Do to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 18 2018, 8:28 PM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.1; 2018-10-23).Oct 18 2018, 9:00 PM

Looks like we are done here!

Fomafix removed a project: Patch-For-Review.Oct 20 2018, 3:40 PM

Forcing type Language on Skin::doEditSectionLink generates a warning on `MinervaNeue` and possibly other skins that override this methodClosed, ResolvedPublicActions

Description

Details

Event Timeline

Forcing type Language on Skin::doEditSectionLink generates a warning on `MinervaNeue` and possibly other skins that override this method
Closed, ResolvedPublic
Actions