Page MenuHomePhabricator

Test failures for Flow\Tests\Collection\...
Open, Needs TriagePublic

Description

Doing a "recheck" solved this and maybe related to T207173?

12:59:54 There were 3 failures:
12:59:54 
12:59:54 1) Flow\Tests\Collection\PostCollectionTest::testGetNextRevision
12:59:54 Failed asserting that null is an instance of class "Flow\Model\PostRevision".
12:59:54 
12:59:54 /workspace/src/extensions/Flow/tests/phpunit/Collection/PostCollectionTest.php:110
12:59:54 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
12:59:54 /workspace/src/maintenance/doMaintenance.php:94
12:59:54 
12:59:54 2) Flow\Tests\Collection\RevisionCollectionPermissionsTest::testPermissions with data set #0 ('confirmedUser', 'view', array(array(true), array(false), array(true)))
12:59:54 User UTFlowConfirmed should be allowed action view on revision new-post : new-post:true suppress-post:false restore-post:true : {"rev_id":"umvz4d2bul5qlhhx","rev_user_id":1,"rev_user_ip":null,"rev_user_wiki":"wikidb-unittest_","rev_parent_id":null,"rev_change_type":"new-post","rev_type":"post","rev_type_id":"umvz4d2buj6phfit","rev_content":"test content","rev_content_url":null,"rev_flags":"html","rev_mod_state":"","rev_mod_user_id":null,"rev_mod_user_ip":null,"rev_mod_user_wiki":null,"rev_mod_timestamp":null,"rev_mod_reason":null,"rev_last_edit_id":null,"rev_edit_user_id":null,"rev_edit_user_ip":null,"rev_edit_user_wiki":null,"rev_content_length":0,"rev_previous_content_length":0,"tree_parent_id":null,"tree_rev_descendant_id":"umvz4d2buj6phfit","tree_rev_id":"umvz4d2bul5qlhhx","tree_orig_user_id":1,"tree_orig_user_ip":null,"tree_orig_user_wiki":"wikidb-unittest_"}
12:59:54 Failed asserting that false matches expected true.
12:59:54 
12:59:54 /workspace/src/extensions/Flow/tests/phpunit/Collection/RevisionCollectionPermissionsTest.php:201
12:59:54 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
12:59:54 /workspace/src/maintenance/doMaintenance.php:94
12:59:54 
12:59:54 3) Flow\Tests\Collection\RevisionCollectionPermissionsTest::testPermissions with data set #4 ('confirmedUser', 'history', array(array(false), array(false)))
12:59:54 User UTFlowConfirmed should not be allowed action history on revision new-post : new-post:false suppress-post:false : {"rev_id":"umvz4e9mtvs3c5hx","rev_user_id":1,"rev_user_ip":null,"rev_user_wiki":"wikidb-unittest_","rev_parent_id":null,"rev_change_type":"new-post","rev_type":"post","rev_type_id":"umvz4e9mttt283it","rev_content":"test content","rev_content_url":null,"rev_flags":"html","rev_mod_state":"","rev_mod_user_id":null,"rev_mod_user_ip":null,"rev_mod_user_wiki":null,"rev_mod_timestamp":null,"rev_mod_reason":null,"rev_last_edit_id":null,"rev_edit_user_id":null,"rev_edit_user_ip":null,"rev_edit_user_wiki":null,"rev_content_length":0,"rev_previous_content_length":0,"tree_parent_id":null,"tree_rev_descendant_id":"umvz4e9mttt283it","tree_rev_id":"umvz4e9mtvs3c5hx","tree_orig_user_id":1,"tree_orig_user_ip":null,"tree_orig_user_wiki":"wikidb-unittest_"}
12:59:54 Failed asserting that true matches expected false.
12:59:54 
12:59:54 /workspace/src/extensions/Flow/tests/phpunit/Collection/RevisionCollectionPermissionsTest.php:201
12:59:54 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
12:59:54 /workspace/src/maintenance/doMaintenance.php:94

Full log here: https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-hhvm-docker/4748/console and triggered patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/468553.

Event Timeline

Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 19 2018, 12:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
D3r1ck01 renamed this task from Test failures for Flow\Test\Collection\... to Test failures for Flow\Tests\Collection\....Oct 19 2018, 12:54 PM
D3r1ck01 updated the task description. (Show Details)
D3r1ck01 updated the task description. (Show Details)
Reedy added a comment.Nov 7 2018, 3:26 PM

Still getting this on a vendor patch..

15:18:17 1) Flow\Tests\Collection\RevisionCollectionPermissionsTest::testPermissions with data set #2 ('confirmedUser', 'view', array(array(false), array(false), array(false), array(false)))
15:18:17 User UTFlowConfirmed should not be allowed action view on revision new-post : new-post:false suppress-post:false restore-post:false suppress-post:false : {"rev_id":"uo2lu2civ7fwdnfn","rev_user_id":1,"rev_user_ip":null,"rev_user_wiki":"wikidb-unittest_","rev_parent_id":null,"rev_change_type":"new-post","rev_type":"post","rev_type_id":"uo2lu2civ5gv9lgj","rev_content":"test content","rev_content_url":null,"rev_flags":"html","rev_mod_state":"","rev_mod_user_id":null,"rev_mod_user_ip":null,"rev_mod_user_wiki":null,"rev_mod_timestamp":null,"rev_mod_reason":null,"rev_last_edit_id":null,"rev_edit_user_id":null,"rev_edit_user_ip":null,"rev_edit_user_wiki":null,"rev_content_length":0,"rev_previous_content_length":0,"tree_parent_id":null,"tree_rev_descendant_id":"uo2lu2civ5gv9lgj","tree_rev_id":"uo2lu2civ7fwdnfn","tree_orig_user_id":1,"tree_orig_user_ip":null,"tree_orig_user_wiki":"wikidb-unittest_"}
15:18:17 Failed asserting that true matches expected false.
15:18:17 
15:18:17 /workspace/src/extensions/Flow/tests/phpunit/Collection/RevisionCollectionPermissionsTest.php:201
15:18:17 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
15:18:17 /workspace/src/maintenance/doMaintenance.php:94

Change 472263 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Flow@master] Temporarily mark flaky tests as broken

https://gerrit.wikimedia.org/r/472263

Change 472263 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Temporarily mark flaky tests as broken

https://gerrit.wikimedia.org/r/472263

Change 472456 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Flow@REL1_32] Temporarily mark flaky tests as broken

https://gerrit.wikimedia.org/r/472456

Change 472456 abandoned by Kosta Harlan:
Temporarily mark flaky tests as broken

Reason:
No comments/activity on this so I assume it's not needed anymore.

https://gerrit.wikimedia.org/r/472456