Page MenuHomePhabricator
Create Task
Maniphest T208003

WatchedItemStore::addWatchBatchForUser does not have outer scope.
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: AWatW9nHN-apXXYuZSe6

message
Wikimedia\Rdbms\LBFactory::commitAndWaitForReplication: WatchedItemStore::addWatchBatchForUser does not have outer scope.
trace
#0 /srv/mediawiki/php-1.33.0-wmf.1/includes/watcheditem/WatchedItemStore.php(744): Wikimedia\Rdbms\LBFactory->getEmptyTransactionTicket()
#1 /srv/mediawiki/php-1.33.0-wmf.1/includes/user/User.php(3935): WatchedItemStore->addWatchBatchForUser()
#2 /srv/mediawiki/php-1.33.0-wmf.1/includes/actions/WatchAction.php(128): User->addWatch()
#3 /srv/mediawiki/php-1.33.0-wmf.1/includes/upload/UploadBase.php(877): WatchAction::doWatch()
#4 /srv/mediawiki/php-1.33.0-wmf.1/includes/api/ApiUpload.php(828): UploadBase->performUpload()
#5 /srv/mediawiki/php-1.33.0-wmf.1/includes/api/ApiUpload.php(146): ApiUpload->performUpload()
#6 /srv/mediawiki/php-1.33.0-wmf.1/includes/api/ApiUpload.php(104): ApiUpload->getContextResult()
#7 /srv/mediawiki/php-1.33.0-wmf.1/includes/api/ApiMain.php(1570): ApiUpload->execute()
#8 /srv/mediawiki/php-1.33.0-wmf.1/includes/api/ApiMain.php(531): ApiMain->executeAction()
#9 /srv/mediawiki/php-1.33.0-wmf.1/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#10 /srv/mediawiki/php-1.33.0-wmf.1/api.php(87): ApiMain->execute()
#11 /srv/mediawiki/w/api.php(3): include()
#12 {main}

#0 /srv/mediawiki/php-1.33.0-wmf.1/includes/watcheditem/WatchedItemStore.php(752): Wikimedia\Rdbms\LBFactory->commitAndWaitForReplication()
#1 /srv/mediawiki/php-1.33.0-wmf.1/includes/user/User.php(3935): WatchedItemStore->addWatchBatchForUser()
#2 /srv/mediawiki/php-1.33.0-wmf.1/includes/actions/WatchAction.php(128): User->addWatch()
#3 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php(480): WatchAction::doWatch()
#4 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityStore.php(154): Wikibase\Repo\Store\WikiPageEntityStore->updateWatchlist()
#5 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/EditEntity.php(810): Wikibase\Lib\Store\TypeDispatchingEntityStore->updateWatchlist()
#6 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/EditEntity.php(759): Wikibase\EditEntity->updateWatchlist()
#7 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Api/EntitySavingHelper.php(351): Wikibase\EditEntity->attemptSave()
#8 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Api/ModifyEntity.php(310): Wikibase\Repo\Api\EntitySavingHelper->attemptSaveEntity()
#9 /srv/mediawiki/php-1.33.0-wmf.1/includes/api/ApiMain.php(1570): Wikibase\Repo\Api\ModifyEntity->execute()
#10 /srv/mediawiki/php-1.33.0-wmf.1/includes/api/ApiMain.php(531): ApiMain->executeAction()
#11 /srv/mediawiki/php-1.33.0-wmf.1/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#12 /srv/mediawiki/php-1.33.0-wmf.1/api.php(87): ApiMain->execute()
#13 /srv/mediawiki/w/api.php(3): include()
#14 {main}

Impact

Notes

In both the DBPerformance and DBQuery logs, not fatal.

Probably caused by https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/464029/

Details

SubjectRepoBranchLines +/-
Use commit-and-wait when processing more than updateRowsPerQuerymediawiki/coremaster+11 -5
Customize query in gerrit

Related Objects

Event Timeline

Addshore created this task.Oct 25 2018, 10:36 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 25 2018, 10:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore updated the task description. (Show Details)Oct 25 2018, 11:42 PM
Addshore moved this task from Untriaged to Aug2019/1.34.wmf.17+ on the Wikimedia-production-error board.
aaron subscribed.Oct 26 2018, 5:55 AM

Does this really need to call commitAndWaitForReplication() when there is only one batch? Is it ever called thousands of times in a row?

• jcrespo merged a task: T208250: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: WatchedItemStore::addWatchBatchForUser does not have outer scope..Oct 29 2018, 5:55 PM
• jcrespo subscribed.
• jcrespo added a comment.Oct 30 2018, 8:15 AM

There is also the, I guess related:

Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: WatchedItemStore::removeWatchBatchForUser does not have outer scope. #0 /srv/mediawiki/php-1.33.0-wmf.1/includes/watcheditem/WatchedItemStore.php(392): Wikimedia\Rdbms\LBFactory->getEmptyTransactionTic
kostajh moved this task from Inbox to Needs Discussion on the Growth-Team board.Oct 30 2018, 3:12 PM
kostajh moved this task from Needs Discussion to Upcoming Work on the Growth-Team board.Oct 31 2018, 6:12 PM
kostajh moved this task from Upcoming Work to Sprint 0 (Growth Team) on the Growth-Team board.Nov 5 2018, 8:12 PM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh claimed this task.Nov 5 2018, 8:18 PM
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot subscribed.Nov 5 2018, 8:54 PM

Change 471806 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] Use commit-and-wait when processing more than updateRowsPerQuery

https://gerrit.wikimedia.org/r/471806

gerritbot added a project: Patch-For-Review.Nov 5 2018, 8:54 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 5 2018, 8:55 PM
kostajh added a comment.Nov 5 2018, 9:39 PM

Does this really need to call commitAndWaitForReplication() when there is only one batch? Is it ever called thousands of times in a row?

@aaron This can happen if you edit raw watchlist and add/remove several thousand items. I added you to the patch for review.

gerritbot added a comment.Nov 6 2018, 7:20 AM

Change 471806 merged by jenkins-bot:
[mediawiki/core@master] Use commit-and-wait when processing more than updateRowsPerQuery

https://gerrit.wikimedia.org/r/471806

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 6 2018, 4:17 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 6 2018, 7:02 PM
Etonkovidova closed this task as Resolved.Nov 14 2018, 1:27 AM
Krinkle moved this task from Aug2019/1.34.wmf.17+ to Resolved on the Wikimedia-production-error board.Jan 25 2019, 10:51 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits