Page MenuHomePhabricator
Create Task
Maniphest T208043

Unknown entity type mediainfo
Closed, ResolvedPublic
Actions

Description

WikibaseMediaInfo seems to be breaking update.php on beta

https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/29313/console

[dea2810c1209218d6406488f] [no req]   InvalidArgumentException from line 59 of /srv/mediawiki-staging/php-master/vendor/wikibase/data-model-services/src/EntityId/EntityIdComposer.php: Unknown entity type mediainfo
Backtrace:
#0 /srv/mediawiki-staging/php-master/extensions/WikibaseMediaInfo/maintenance/Util/PagePropsUpdateGenerator.php(36): Wikibase\\DataModel\\Services\\EntityId\\EntityIdComposer->composeEntityId(string, string, string)
#1 /srv/mediawiki-staging/php-master/includes/utils/BatchRowUpdate.php(91): Wikibase\\MediaInfo\\Maintenance\\Util\\PagePropsUpdateGenerator->update(stdClass)
#2 /srv/mediawiki-staging/php-master/extensions/WikibaseMediaInfo/maintenance/CreatePageProps.php(75): BatchRowUpdate->execute()
#3 /srv/mediawiki-staging/php-master/maintenance/Maintenance.php(1698): Wikibase\\MediaInfo\\Maintenance\\CreatePageProps->doDBUpdates()
#4 /srv/mediawiki-staging/php-master/maintenance/update.php(215): LoggedUpdateMaintenance->execute()
#5 /srv/mediawiki-staging/php-master/maintenance/doMaintenance.php(94): UpdateMediaWiki->execute()
#6 /srv/mediawiki-staging/php-master/maintenance/update.php(248): include(string)
#7 /srv/mediawiki-staging/multiversion/MWScript.php(100): include(string)
#8 {main}

Details

SubjectRepoBranchLines +/-
BETA: wmgUseWikibaseMediaInfo false (again)operations/mediawiki-configmaster+1 -1
Don't use WikibaseRepo for CreatePageProps EntityIdComposermediawiki/extensions/WikibaseMediaInfomaster+17 -3
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Oct 26 2018, 12:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2018, 12:23 PM
Reedy triaged this task as High priority.Oct 26 2018, 12:23 PM
greg subscribed.Oct 26 2018, 4:31 PM

Since Oct 25, 2018 3:20 PM / https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/29292/console

thcipriani subscribed.Oct 26 2018, 6:29 PM
Addshore subscribed.Oct 27 2018, 8:06 AM

If we need to unblock the beta build we can just stop loading the MediaInfo extension on beta for now.
I can look at this in more detail on monday.

gerritbot subscribed.Oct 27 2018, 8:20 AM

Change 470140 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] BETA: wmgUseWikibaseMediaInfo false (again)

https://gerrit.wikimedia.org/r/470140

gerritbot added a project: Patch-For-Review.Oct 27 2018, 8:20 AM
gerritbot added a comment.Oct 27 2018, 8:23 AM

Change 470140 merged by jenkins-bot:
[operations/mediawiki-config@master] BETA: wmgUseWikibaseMediaInfo false (again)

https://gerrit.wikimedia.org/r/470140

Stashbot subscribed.Oct 27 2018, 8:24 AM

Mentioned in SAL (#wikimedia-operations) [2018-10-27T08:24:45Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings-labs.php: BETA ONLY T208043 (duration: 01m 06s)

Jdforrester-WMF removed a project: Patch-For-Review.Oct 29 2018, 8:25 PM
gerritbot added a comment.Oct 29 2018, 9:09 PM

Change 470470 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseMediaInfo@master] Don't use WikibaseRepo for CreatePageProps EntityIdComposer

https://gerrit.wikimedia.org/r/470470

gerritbot added a project: Patch-For-Review.Oct 29 2018, 9:10 PM
Addshore mentioned this in rEWBI006fb1f1e5ae: Don't use WikibaseRepo for CreatePageProps EntityIdComposer.Oct 29 2018, 9:12 PM
Addshore mentioned this in rEWBIc4fc3a44cf5d: Don't use WikibaseRepo for CreatePageProps EntityIdComposer.Oct 29 2018, 9:15 PM
Addshore mentioned this in rEWBIe36687015f4e: Don't use WikibaseRepo for CreatePageProps EntityIdComposer.
gerritbot added a comment.Oct 29 2018, 10:27 PM

Change 470470 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Don't use WikibaseRepo for CreatePageProps EntityIdComposer

https://gerrit.wikimedia.org/r/470470

Stashbot added a comment.Oct 29 2018, 10:54 PM

Mentioned in SAL (#wikimedia-releng) [2018-10-29T22:54:09Z] <James_F> Manually triggered a beta-update-databases-eqiad run to see if our fix for T208043 has worked.

Jdforrester-WMF closed this task as Resolved.Oct 29 2018, 10:57 PM
Jdforrester-WMF assigned this task to Addshore.
Restricted Application added a project: User-Addshore. · View Herald TranscriptOct 29 2018, 10:57 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 29 2018, 11:01 PM
Addshore moved this task from Incoming to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Nov 1 2018, 2:06 PM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore moved this task from To Do (prioritised from top to bottom) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL