Page MenuHomePhabricator
Create Task
Maniphest T208595

First context menu shown after opening the page is all broken
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
matmarex
Nov 2 2018, 3:12 PM
Tags
Referenced Files
F27069951: image.png
Nov 5 2018, 8:17 PM
F27069456: image.png
Nov 5 2018, 7:47 PM
F27030379: image.png
Nov 3 2018, 12:53 PM
F27020213: image.png
Nov 2 2018, 3:12 PM
Subscribers
Aklapper
Esanders
Jdforrester-WMF
matmarex
TerraCodes
Volker_E

Description

First context menu shown after opening the page is all broken.

image.png (980×1 px, 234 KB)

Clicking elsewhere and then again in the previous place displays a normal context menu.

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.29.4mediawiki/coremaster+336 -58
OOUI: Backport I407b0d6fe7b81465054b640d4b5ac4bf352a9901mediawiki/coremaster+0 -9
FloatableElement: Remove check for 'needsCustomPosition'oojs/uimaster+0 -9
Customize query in gerrit

Event Timeline

matmarex created this task.Nov 2 2018, 3:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2018, 3:12 PM
Esanders added subscribers: Volker_E, Esanders.Nov 3 2018, 12:53 PM

Seeing this too, wonder if this is related to the issue I saw with the notices popup:

image.png (162×482 px, 16 KB)

i.e. an OOUI regression? Was any OOUI popup code changed?

Esanders added a project: Regression.Nov 3 2018, 12:53 PM
Esanders added a comment.EditedNov 3 2018, 12:56 PM

Locally bisecting it's definitely an OOUI regression, most likely https://gerrit.wikimedia.org/r/#/c/oojs/ui/+/467000/

Esanders triaged this task as Unbreak Now! priority.Nov 3 2018, 1:01 PM
Esanders added a project: OOUI.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptNov 3 2018, 1:01 PM
Esanders added a comment.Nov 3 2018, 1:05 PM

Setting needsCustomPosition to true appears to fix this. Bartosz suggesting removing that check in the patch, but I'll leave it up to him.

Jdforrester-WMF subscribed.Nov 5 2018, 7:00 PM

Ping. Train will depart in 24 hours with or without a fix to this…

matmarex claimed this task.Nov 5 2018, 7:19 PM
matmarex added a comment.Nov 5 2018, 7:47 PM
In T208595#4717848, @Esanders wrote:

Seeing this too, wonder if this is related to the issue I saw with the notices popup:

image.png (162×482 px, 16 KB)

I think this is not related to the other issue. I couldn't reproduce this under normal circumstances, but it does happen when you make your browser window ridiculously tiny (there has to be more space above the toolbar than below it):

image.png (187×1 px, 27 KB)

matmarex added a comment.Nov 5 2018, 7:48 PM

Patch for that: https://gerrit.wikimedia.org/r/#/c/oojs/ui/+/471790 (not marking against this task since this is a bit off-topic).

gerritbot subscribed.Nov 5 2018, 8:13 PM

Change 471796 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] FloatableElement: Remove check for 'needsCustomPosition'

https://gerrit.wikimedia.org/r/471796

gerritbot added a project: Patch-For-Review.Nov 5 2018, 8:13 PM

Change 471797 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] OOUI: Backport I407b0d6fe7b81465054b640d4b5ac4bf352a9901

https://gerrit.wikimedia.org/r/471797

matmarex added a comment.Nov 5 2018, 8:17 PM

@Esanders Thanks for debugging.

The issue can also be reproduced in the OOUI demo. Visit https://doc.wikimedia.org/oojs-ui/master/demos/?page=dialogs, open "PopupButtonWidget test" at the bottom, and uncheck "Use overlay". All of the popups will display below/forwards when opened for the first time, regardless of how they should be displayed.

image.png (425×743 px, 49 KB)

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Nov 5 2018, 8:23 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Nov 5 2018, 8:33 PM

Change 471796 merged by jenkins-bot:
[oojs/ui@master] FloatableElement: Remove check for 'needsCustomPosition'

https://gerrit.wikimedia.org/r/471796

gerritbot added a comment.Nov 5 2018, 10:09 PM

Change 471797 merged by jenkins-bot:
[mediawiki/core@master] OOUI: Backport I407b0d6fe7b81465054b640d4b5ac4bf352a9901

https://gerrit.wikimedia.org/r/471797

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Nov 5 2018, 10:21 PM
Jdforrester-WMF edited projects, added VisualEditor-EditingTools; removed Patch-For-Review.Nov 5 2018, 10:28 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Nov 6 2018, 1:03 AM
Ryasmeen added a project: Verified.Nov 6 2018, 1:06 AM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 6 2018, 7:03 PM
gerritbot added a comment.Nov 7 2018, 1:03 AM

Change 472080 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.29.4

https://gerrit.wikimedia.org/r/472080

gerritbot added a project: Patch-For-Review.Nov 7 2018, 1:03 AM
gerritbot added a comment.Nov 7 2018, 1:57 AM

Change 472080 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.4

https://gerrit.wikimedia.org/r/472080

Volker_E closed this task as Resolved.Nov 12 2018, 12:54 AM
Volker_E moved this task from Backlog to OOUI-0.29.4 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.29.4); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
Liuxinyu970226 unsubscribed.Nov 19 2018, 1:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL