Page MenuHomePhabricator
Create Task
Maniphest T208920

MFA: add tests for Drawer and CtaDrawer
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

Currently CtaDrawer.js and Drawer.js have no test coverage and this makes me a sad panda. This task aims to make this 100%.

Precursors:

  • Ensure T207805 has happened before beginning on this change. Tests for tests/qunit/mobile.references/ReferencesDrawer.test.js do exist, and we'll want to ensure the initial figure for code coverage on the wiki page is accurate before starting this work.

Developer notes

The Drawer and CtaDrawer are mostly logic-less templates. They do not contain gateways and are unlikely to need any kind of refactoring.

Sign off steps

Coverage should be 100%. If not, and there is a reason, please make a note on the table. If coverage is not 100% push this back to needs more work to find out why.

Details

SubjectRepoBranchLines +/-
Hygiene: add tests for CtaDrawermediawiki/extensions/MobileFrontendmaster+250 -33
Hygiene: add tests for Drawermediawiki/extensions/MobileFrontendmaster+191 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Nov 7 2018, 12:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2018, 12:47 AM
Jdlrobson triaged this task as Medium priority.Nov 7 2018, 12:47 AM
Jdlrobson added a parent task: T195478: [EPIC] Speed up unit test execution and increase code coverage.Nov 7 2018, 12:54 AM
Jdlrobson added a project: MobileFrontend (MobileFrontend and MinervaNeue architecture).
Jdlrobson set the point value for this task to 4.Nov 7 2018, 5:35 PM

We were jumping between a 5 and a 3 on this one.

Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.Nov 13 2018, 12:23 AM
Jdlrobson renamed this task from Test coverage for Drawer and CtaDrawer to MFA: Test coverage for Drawer and CtaDrawer.Nov 15 2018, 6:52 PM
Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Nov 16 2018, 6:26 PM
Jdlrobson moved this task from Upcoming to Readers-Web-Kanbanana-Board-2018-19-Q2 on the Web-Team-Backlog board.
Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.
• Niedzielski claimed this task.Nov 19 2018, 3:45 PM
• Niedzielski moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
• Niedzielski renamed this task from MFA: Test coverage for Drawer and CtaDrawer to MFA: add tests for Drawer and CtaDrawer.Nov 28 2018, 11:32 PM
gerritbot subscribed.Nov 28 2018, 11:41 PM

Change 476428 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: add tests for Drawer

https://gerrit.wikimedia.org/r/476428

gerritbot added a project: Patch-For-Review.Nov 28 2018, 11:41 PM
gerritbot added a comment.Nov 29 2018, 1:36 AM

Change 476428 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Hygiene: add tests for Drawer

https://gerrit.wikimedia.org/r/476428

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Nov 29 2018, 2:00 AM
gerritbot added a comment.Nov 29 2018, 7:50 PM

Change 476607 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: add test for CtaDrawer

https://gerrit.wikimedia.org/r/476607

• Niedzielski removed • Niedzielski as the assignee of this task.Nov 29 2018, 7:50 PM
• Niedzielski moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
• Niedzielski subscribed.
Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 30 2018, 12:34 AM
Jdlrobson updated the task description. (Show Details)Nov 30 2018, 1:11 AM
• Niedzielski claimed this task.Nov 30 2018, 2:58 PM
• Niedzielski moved this task from Needs More Work to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
• Niedzielski removed • Niedzielski as the assignee of this task.Nov 30 2018, 3:26 PM
• Niedzielski moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 30 2018, 4:16 PM
• Niedzielski claimed this task.Dec 3 2018, 6:06 PM
• Niedzielski moved this task from Needs More Work to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
• Niedzielski removed • Niedzielski as the assignee of this task.Dec 3 2018, 7:10 PM
• Niedzielski moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
• nray claimed this task.Dec 4 2018, 6:42 PM
• nray removed • nray as the assignee of this task.Dec 5 2018, 2:18 AM
• nray moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
• nray subscribed.
• Niedzielski moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 6 2018, 7:38 PM
• nray claimed this task.Dec 6 2018, 8:34 PM
• nray removed • nray as the assignee of this task.Dec 6 2018, 11:53 PM
gerritbot added a comment.Dec 7 2018, 5:35 PM

Change 476607 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: add tests for CtaDrawer

https://gerrit.wikimedia.org/r/476607

• nray moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 7 2018, 8:47 PM
phuedx subscribed.Dec 11 2018, 1:06 PM

Coverage should be 100%. If not, and there is a reason, please make a note on the table. If coverage is not 100% push this back to needs more work to find out why.

When I run npm run coverage I see the following:

| CtaDrawer.js                    |      100 |      100 |      100 |      100 |                   |
| Drawer.js                       |      100 |      100 |      100 |      100 |                   |
phuedx updated the task description. (Show Details)Dec 11 2018, 1:13 PM
phuedx updated the task description. (Show Details)
  • Record progress

https://www.mediawiki.org/w/index.php?title=Reading%2FWeb%2FProjects%2FInvest_in_the_MobileFrontend_%26_MinervaNeue_frontend_architecture%2FProgress&type=revision&diff=3004784&oldid=2988495

phuedx added a comment.Dec 11 2018, 1:31 PM

This change affects the call to action shown to an anonymous user when they click the watchstar and affects the reference drawer so both of those should be tested.

phuedx claimed this task.Dec 11 2018, 1:31 PM
phuedx added a comment.Dec 11 2018, 3:18 PM
In T208920#4813708, @phuedx wrote:

This change affects the call to action shown to an anonymous user when they click the watchstar and affects the reference drawer so both of those should be tested.

Both features work just fine on the Beta Cluster.

phuedx closed this task as Resolved.Dec 11 2018, 3:18 PM
phuedx moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

Being bold.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits