Let file captions be edited on Mobile Frontend
Open, HighPublic

Description

The mobile web view of Commons lacks an edit button to initiate editing of captions. See image below.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2018, 8:16 PM
Ramsey-WMF triaged this task as High priority.Nov 7 2018, 8:17 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptNov 7 2018, 8:17 PM

Change 472345 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] WIP: Mobile editing of captions, sort-of

https://gerrit.wikimedia.org/r/472345

With some hacking around in the Wikibase code, I got the code executing and it works fine (but looks ugly as sin):

Happy to do a mobile-specific set of styling, but first we need to determine with the Wikibase team whether this approach is OK by them.

Jdforrester-WMF moved this task from To Do to Doing on the SDC Engineering board.Nov 7 2018, 10:53 PM

Some quick styling changes gets us to:

Read modeEdit mode

Proper mobile design is not possible given how the items are rendered on the page right now, sadly. :-(

Proper mobile design is not possible given how the items are rendered on the page right now, sadly. :-(

This is good enough for v1, I think :)

You mentioned earlier wanting to check in with Team Wikibase on these changes. Have you initiated that already or shall I?

Proper mobile design is not possible given how the items are rendered on the page right now, sadly. :-(

This is good enough for v1, I think :)

You mentioned earlier wanting to check in with Team Wikibase on these changes. Have you initiated that already or shall I?

I'll do it.

Ramsey-WMF moved this task from Untriaged to Triaged on the Multimedia board.Nov 8 2018, 10:01 PM
Ramsey-WMF moved this task from Triaged to Next up on the Multimedia board.Nov 8 2018, 10:06 PM
Cparle added a subscriber: Cparle.Nov 9 2018, 12:34 PM

Proper mobile design is not possible given how the items are rendered on the page right now, sadly. :-(

@Jdforrester-WMF will T204934 fix that?

Proper mobile design is not possible given how the items are rendered on the page right now, sadly. :-(

@Jdforrester-WMF will T204934 fix that?

Yes. Something to work on once we're in prod. :-)

Proper mobile design is not possible given how the items are rendered on the page right now, sadly. :-(

@Jdforrester-WMF will T204934 fix that?

Yes. Something to work on once we're in prod. :-)

Specifically that looks like implementation of T201463.

Jdforrester-WMF renamed this task from Beta Commons: File Captions can't be edited on mobile browsers to Let file captions be edited on Mobile Frontend.Fri, Jan 11, 9:52 PM
Jdforrester-WMF updated the task description. (Show Details)

The Structured data header is also missing on mobile:

Related to the styling changes above, if mobile web follows the Upload Wizard pattern, we'll get more width for the caption text: