The mobile web view of Commons lacks an edit button to initiate editing of captions. See image below.
Description
Details
Related Objects
- Mentioned In
- T215893: Bugs with captions on mobile
T215818: Improvements to the Captions mobile experience
rEWBIda8ee5f86365: Mobile editing of captions
T205732: Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions)
rEWBI0d32b29fef29: Mobile editing of captions
rEWBIf900384ed62c: WIP: Mobile editing of captions
rEWBI300be43ed67e: WIP: Mobile editing of captions, sort-of - Mentioned Here
- T215893: Bugs with captions on mobile
T215818: Improvements to the Captions mobile experience
T201463: Mobile multilingual caption editing via Wikipedia
T204934: Use OOUI Layouts instead of table to display/edit multi-lingual captions on File page
Event Timeline
Change 472345 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] WIP: Mobile editing of captions, sort-of
With some hacking around in the Wikibase code, I got the code executing and it works fine (but looks ugly as sin):
Happy to do a mobile-specific set of styling, but first we need to determine with the Wikibase team whether this approach is OK by them.
Some quick styling changes gets us to:
Read mode | Edit mode |
---|---|
Proper mobile design is not possible given how the items are rendered on the page right now, sadly. :-(
Proper mobile design is not possible given how the items are rendered on the page right now, sadly. :-(
This is good enough for v1, I think :)
You mentioned earlier wanting to check in with Team Wikibase on these changes. Have you initiated that already or shall I?
Proper mobile design is not possible given how the items are rendered on the page right now, sadly. :-(
@Jdforrester-WMF will T204934 fix that?
The Structured data header is also missing on mobile:
Related to the styling changes above, if mobile web follows the Upload Wizard pattern, we'll get more width for the caption text:
Change 472344 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Wikibase@master] Enable a few lib and repo RL modules in mobile target for SDC
Change 472344 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable a few lib and repo RL modules in mobile target for SDC
Change 472345 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Mobile editing of captions
This isn't working on TestCommons for some reason. Am digging in.
Ignore that, TestCommons flipped back to wmf.14 without me noticing. All looks good.
Tested but not working properly.
Bugs found when editing while not logged in (both on Safari and Chrome on iOS):
- Attempts to add a NEW English Caption results in "Revision with ID not found" error. Editing existing captions seems to work fine for some files (on this image, editing a caption worked)
- Additionally, on the link above, the English caption I added via the desktop web interface ended up showing twice on the mobile interface after page refresh.
- Also, the entire caption section appears TWICE on the page; once in the correct place, but again just under the "Original Upload Log" section.
- On some files, existing captions do not appear at all on the mobile interface (this file as an example, which has both an existing English and German caption but neither appear in the mobile interface)
I have some feedback I'd like you to consider that will make the Captions mobile experience better:
current implementation | recommended design |
Issues with current implementation:
- Trash can is awkwardly placed
- There is no gap between the language dropdown and the caption field, making it look like they run into each other
- The width of the caption field is too short and the help text is impossible to read
Recommended changes
- Move trash can to the same line as the language dropdown (just like Upload Wizard)
- There needs to be a gap between the language dropdown and the caption field
- Make the width of the caption field longer. Could go as far as to the end of “Publish changes”
Erm ... guys, if patches for this ticket have been merged and are now live (which they have and they are), then IMO it's better to create new tickets for any outstanding issues rather than keep adding to this ticket