Page MenuHomePhabricator

PayPal recurring audit 10/21/2018 duplicate
Closed, ResolvedPublic2 Estimated Story Points

Description

cid=12043254 shows the same PayPal recurring donation twice, 5HY31492EJ451064M (thanks for spotting, @krobinson)

@Ejegg I know PayPal's been wobbly with the recurring audit files of late, just fyi in case there are more of these.

Event Timeline

I believe this has to do with the paypal recurring issues we've been dealing with previously. I need to prove that out some more, but from what I'm seeing so far there shouldn't be many of these, and the issue shouldn't happen again.

Basically one of these looks like it came in on PayPal legacy, and the other on PayPal EC at the same time. Given that we've addressed those problems, I don't think we'll see this in the future.

@XenoRyet I see 105 rows from this query:

select count(*)
from wmf_contribution_extra wca1
inner join wmf_contribution_extra wca2
on wca1.gateway_txn_id = wca2.gateway_txn_id
and wca1.gateway='paypal'
and wca2.gateway='paypal_ec'
and wca1.id > 55000000
and wca2.id > 55000000;

Are you sure we're out of the woods? We should at least delete the 105 duplicate rows, right?

Shoot, there's at least 1 from last Wednesday, and we haven't deployed any additional fixes since then. Think we might need to fix something in the audit parser.

Yea, found the one from 11/14 as well, so looks like we're not as done with this as I suspected.

Looks like the listener is recognizing these as legacy, and the parser is seeing them as EC. Let me look and see which they should properly be.

Ejegg triaged this task as Medium priority.
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint XML ate my homework board.

Change 480116 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/tools@master] PayPal audit: avoid duplicating I- legacy subscriptions

https://gerrit.wikimedia.org/r/480116

Change 480116 merged by jenkins-bot:
[wikimedia/fundraising/tools@master] PayPal audit: avoid duplicating I- legacy subscriptions

https://gerrit.wikimedia.org/r/480116

Change 480795 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Clean up duplicate transactions added by PayPal audit

https://gerrit.wikimedia.org/r/480795

Change 480795 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Clean up duplicate transactions added by PayPal audit

https://gerrit.wikimedia.org/r/480795

Ejegg set the point value for this task to 2.Oct 28 2019, 3:54 PM