Page MenuHomePhabricator
Create Task
Maniphest T210559

Can't scroll the viewport while typing in the caption field in Gallery>Images on mobile
Closed, ResolvedPublic
Actions

Description

Steps to replicate:

  1. Open mobile VE.
  2. Go to Gallery>Images tab.
  3. Place your cursor inside the caption field.
  4. When the keyboard slides up, try to scroll down to see what you are typing.

It's not possible to scroll the viewport to the area. Works correctly for Gallery caption field on Options tab.

Details

SubjectRepoBranchLines +/-
ve.init.mw.MobileFrontendArticleTarget: Disable iOS scrolling hack while in dialogmediawiki/extensions/MobileFrontendmaster+6 -4
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Nov 27 2018, 11:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 27 2018, 11:07 PM
Ryasmeen mentioned this in T203477: Improve gallery dialog for mobile visual editor.Nov 27 2018, 11:10 PM
matmarex edited projects, added VisualEditor (Current work), VisualEditor-MediaWiki; removed VisualEditor.Dec 11 2018, 10:59 AM
matmarex subscribed.

I can reproduce this. I think it's actually more serious that it looked like – it seems what whenever the keyboard is used while any VE dialog is open, the viewport is continually scrolled to the top. This makes it nearly impossible to type in fields in the "bottom half" of dialogs, such as the gallery image caption field, but also affects e.g. fields in the options tab of gallery dialog, and other dialogs like the maps dialog.

RRPG5061.MP43 MBDownload

WCUN3487.MP42 MBDownload

gerritbot subscribed.Dec 11 2018, 11:00 AM

Change 478893 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] ve.init.mw.MobileFrontendArticleTarget: Disable scrolling hack while in dialog

https://gerrit.wikimedia.org/r/478893

gerritbot added a project: Patch-For-Review.Dec 11 2018, 11:00 AM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Dec 11 2018, 1:44 PM
gerritbot added a comment.Dec 11 2018, 1:59 PM

Change 478893 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] ve.init.mw.MobileFrontendArticleTarget: Disable iOS scrolling hack while in dialog

https://gerrit.wikimedia.org/r/478893

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 11 2018, 3:01 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Dec 11 2018, 8:24 PM
Ryasmeen added a project: Editing QA.Dec 11 2018, 10:29 PM
Ryasmeen edited projects, added Verified; removed Editing QA, Patch-For-Review.Dec 11 2018, 10:47 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• marcella closed this task as Resolved.Dec 14 2018, 4:16 PM
• marcella claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 14 2018, 4:16 PM
matmarex mentioned this in T212967: Help panel: textarea not visible when editing in VE mode on mobile.Jan 10 2019, 8:16 PM
matmarex mentioned this in T215604: Can’t scroll to bottom of link dialog on iOS mobile VE while keyboard is open.Feb 8 2019, 1:01 PM
• ppelberg subscribed.Mar 8 2019, 6:45 AM
• ppelberg unsubscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL