Page MenuHomePhabricator

[Bug] Remove download button from pages that don't exist
Open, NormalPublic

Description

Steps to Reproduce

Visit a missing page. For example, https://en.m.wikipedia.org/wiki/Stephen_Niedzielski.

Expected Results

  • No download icon shows

Actual Results

  • The download icon shows

Environments Observed

  • enwiki prod

Browser Version

  • Chrome v71.0.3578.57

OS Version

  • Chrome OS v71.0.3578.57

Device Model

  • Pixel Slate

Device Language

  • English

Developer notes

The download icon is injected via JavaScript. That JavaScript should now consider whether the page exists or not.

Event Timeline

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptDec 12 2018, 3:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson added a subscriber: Jdlrobson.

Note, some pages that don't exist will have talk pages in the case of deletion and there's nothing stopping someone from talking about a page that doesn't exist (e.g. to request it's creation or to link to a draft). Similarly, it's useful to watch such a page in case it gets created (for example imagine a curse word - an editor might want to check that page doesn't request)

That said, there seems little reason for the language and download icons

That said, there seems little reason for the language and download icons

Now I'm wondering if the language button is useful in the case that it's deleted on one wiki but another :|

I guess I don't have much in the way of concrete suggestions!

Yea the relationship between the page and the talk page is a bit confusing. In some ways they are separate, but "Watch" applies to both of them.

Perhaps we just ditch the edit pen and the download icon in this case?

Personally I find it useful to see a faded out language button as it tells me a page needs translations. I'm sure it's helpful to other editors too and I'd hope that the consistent appearance of this icon is useful for users trying to learn the experience.

The download icon as I understand it, will long term move to an overspill menu. I feel like concentrating efforts on making that happen would remove that as a problem.

Perhaps we just ditch the edit pen

Why would we ditch the edit pen? On many projects encouraging creation is a feature!

Perhaps we just ditch the edit pen

Why would we ditch the edit pen? On many projects encouraging creation is a feature!

Oh duh, good point. Ok so can we close this task then, or at least scope it down to "remove download action from non-existent pages"? It doesn't seem like there is anything else actionable here.

Jdlrobson renamed this task from [Bug] Talk, watchstar, download, and language buttons should not appear on missing page to [Bug] Remove download button from pages that don't exist.Apr 2 2019, 9:22 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Analysis to Triaged but Future on the Readers-Web-Backlog board.