[Bug] Remove download button from pages that don't exist
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Niedzielski
	Dec 12 2018, 3:50 PM

Description

Steps to Reproduce

Visit a missing page. For example, https://en.m.wikipedia.org/wiki/Stephen_Niedzielski.

Expected Results

No download icon shows

Actual Results

The download icon shows

Environments Observed

enwiki prod

Browser Version

Chrome v71.0.3578.57

OS Version

Chrome OS v71.0.3578.57

Device Model

Pixel Slate

Device Language

English

Developer notes

The download icon is injected via JavaScript. That JavaScript should now consider whether the page exists or not.

QA steps

Use https://en.m.wikipedia.beta.wmflabs.org/wiki/Stephen_Niedzielski. for the non-existent page
and https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain for an existent page.

Details

	Subject	Repo	Branch	Lines +/-
	Don't show download button on missing pages	mediawiki/skins/MinervaNeue	master	+18 -6

Customize query in gerrit

Related Objects

Mentioned In: rSKIN837ccdaad0b1: Update git submodules
T219027: [Bug] User page with no history, missing toolbar actions
T220114: Updates to user page treatment (apply for IP address and always show toolbar)
T201339: Cannot access user contributions when following red link to user page on mobile

Event Timeline

• Niedzielski created this task.Dec 12 2018, 3:50 PM

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptDec 12 2018, 3:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Dec 12 2018, 4:43 PM

Note, some pages that don't exist will have talk pages in the case of deletion and there's nothing stopping someone from talking about a page that doesn't exist (e.g. to request it's creation or to link to a draft). Similarly, it's useful to watch such a page in case it gets created (for example imagine a curse word - an editor might want to check that page doesn't request)

That said, there seems little reason for the language and download icons

That said, there seems little reason for the language and download icons

Now I'm wondering if the language button is useful in the case that it's deleted on one wiki but another :|

I guess I don't have much in the way of concrete suggestions!

Yea the relationship between the page and the talk page is a bit confusing. In some ways they are separate, but "Watch" applies to both of them.

Perhaps we just ditch the edit pen and the download icon in this case?

• alexhollender_WMF moved this task from Needs analysis to Queue on the Web-Team-Backlog (Design) board.Apr 2 2019, 8:58 PM

Personally I find it useful to see a faded out language button as it tells me a page needs translations. I'm sure it's helpful to other editors too and I'd hope that the consistent appearance of this icon is useful for users trying to learn the experience.

The download icon as I understand it, will long term move to an overspill menu. I feel like concentrating efforts on making that happen would remove that as a problem.

Perhaps we just ditch the edit pen

Why would we ditch the edit pen? On many projects encouraging creation is a feature!

In T211775#5079430, @Jdlrobson wrote:

Perhaps we just ditch the edit pen

Why would we ditch the edit pen? On many projects encouraging creation is a feature!

Oh duh, good point. Ok so can we close this task then, or at least scope it down to "remove download action from non-existent pages"? It doesn't seem like there is anything else actionable here.

Jdlrobson renamed this task from [Bug] Talk, watchstar, download, and language buttons should not appear on missing page to [Bug] Remove download button from pages that don't exist.Apr 2 2019, 9:22 PM

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Design).

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.

• alexhollender_WMF mentioned this in T201339: Cannot access user contributions when following red link to user page on mobile.Apr 4 2019, 2:26 PM

• alexhollender_WMF mentioned this in T220114: Updates to user page treatment (apply for IP address and always show toolbar).Apr 4 2019, 4:30 PM

• alexhollender_WMF mentioned this in T219027: [Bug] User page with no history, missing toolbar actions.May 21 2019, 10:11 PM

Jdlrobson moved this task from Triaged but Future to Readers-Web-Kanbanana-2019-20-Q1 on the Web-Team-Backlog board.Jul 31 2019, 7:01 PM

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog.

Jdlrobson moved this task from Needs Analysis to Blocked on Others on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Change 526794 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Don't show download button on missing pages

https://gerrit.wikimedia.org/r/526794

gerritbot added a project: Patch-For-Review.Jul 31 2019, 11:18 PM

Jdlrobson assigned this task to Edtadros.Aug 1 2019, 5:16 PM

Jdlrobson moved this task from Blocked on Others to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Jdlrobson updated the task description. (Show Details)

Change 526794 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Don't show download button on missing pages

https://gerrit.wikimedia.org/r/526794

Restricted Repository Identity mentioned this in rSKIN837ccdaad0b1: Update git submodules.Aug 1 2019, 5:26 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Aug 1 2019, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 1 2019, 6:11 PM

MBinder_WMF reassigned this task from Edtadros to pmiazga.Aug 7 2019, 5:22 PM

MBinder_WMF added a subscriber: Edtadros.