Page MenuHomePhabricator

Call to a member function format() on a non-object (boolean)
Closed, ResolvedPublic

Description

Noticed in Fatal-Monitor after deploying 1.33.0-wmf.8 to group1

[{exception_id}] {exception_url} BadMethodCallException from line 394 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/EventBus/includes/EventBus.php: Call to a member function format() on a non-object (boolean)

Reoccurance of T210608

Event Timeline

zeljkofilipin triaged this task as Unbreak Now! priority.Dec 12 2018, 6:35 PM
zeljkofilipin created this task.
Restricted Application added a project: Analytics. · View Herald TranscriptDec 12 2018, 6:35 PM
Restricted Application changed the subtype of this task from "Release" to "Task". · View Herald Transcript
Restricted Application added subscribers: Liuxinyu970226, TerraCodes, Aklapper. · View Herald Transcript

Looks like the only thing that changed in EventBus from wmf.6 to wmf.8 is this, and it does not look related. 😐

https://www.mediawiki.org/wiki/MediaWiki_1.33/wmf.8#EventBus
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventBus/+/478721

Adding @dcausse, @mobrovac and @Pchelolo since they were active in Gerrit patch.

I think this is the reason and in particular @mobrovac last comment that for some reason went unnoticed.

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/EventBus/+/476314/ was only SWATed into wmf.6 and it was not merged into master.

Change 479260 had a related patch set uploaded (by Ppchelko; owner: Mobrovac):
[mediawiki/extensions/EventBus@master] Revert "Revert "Revert "Set event datetime with microsecond resolution."""

https://gerrit.wikimedia.org/r/479260

Reedy updated the task description. (Show Details)Dec 12 2018, 8:40 PM

Change 479272 had a related patch set uploaded (by Reedy; owner: Mobrovac):
[mediawiki/extensions/EventBus@wmf/1.33.0-wmf.8] Revert "Revert "Revert "Set event datetime with microsecond resolution."""

https://gerrit.wikimedia.org/r/479272

Change 479260 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] Revert "Revert "Revert "Set event datetime with microsecond resolution."""

https://gerrit.wikimedia.org/r/479260

Change 479272 merged by jenkins-bot:
[mediawiki/extensions/EventBus@wmf/1.33.0-wmf.8] Revert "Revert "Revert "Set event datetime with microsecond resolution."""

https://gerrit.wikimedia.org/r/479272

Mentioned in SAL (#wikimedia-operations) [2018-12-12T21:48:24Z] <reedy@deploy1001> Synchronized php-1.33.0-wmf.8/extensions/EventBus: T211805 (duration: 00m 53s)

Reedy closed this task as Resolved.Dec 12 2018, 9:48 PM
Reedy assigned this task to Pchelolo.
Reedy removed a project: Patch-For-Review.