See parent task.
Filing this because of https://phabricator.wikimedia.org/D1092 , if move has already happened in the meantime or if I misinterpret, please correct. Thanks.
(History: https://phabricator.wikimedia.org/T148651 )
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use KafkaSSE from github instead of diffusion | mediawiki/services/eventstreams | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T330844 Avoid to have too much different places (like Gerrit, GitHub, Differential, GitLab, ...) where code review may take place to help newcomers | |||
| Resolved | Aklapper | T342041 Remove custom src/customfields/DifferentialApplyPatchWithOnlyGitField.php | |||
| Resolved | Aklapper | T330797 Uninstall Differential (Phabricator application) | |||
| Resolved | Aklapper | T324131 Remove "Active Differential users" stats from monthly community_metrics.sh email | |||
| Resolved | Aklapper | T191182 Migrate active repositories in Phabricator Differential to GitLab | |||
| Resolved | Ottomata | T212420 Move KafkaSSE development from Differential to Github |
Event Timeline
Comment Actions
For this particular project, I'd like to move to github. This is a generic library that is non mediawiki specific. I'll try to work on this soon.
Comment Actions
Change 482697 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[mediawiki/services/eventstreams@master] Use KafkaSSE from github instead of diffusion
Comment Actions
Change 482697 merged by Ottomata:
[mediawiki/services/eventstreams@master] Use KafkaSSE from github instead of diffusion
Comment Actions
The next time we build/deploy EventStreams, KafkaSSE from diffusion will no longer be used. Can we close this? Should we delete the repo from diffusion?
Comment Actions
It's unclear what being non-mediawiki specific has to do with picking github? We have plenty of non-MediaWiki specific code on Gerrit.
More generally, it's extremely helpful that you (and others) document the reasons for picking a proprietary service over the free, privacy-friendly one we're investing resources in supporting so we can make improvements as necessary. Thanks!
Comment Actions
Most of the time I'm mostly unoppionated and am all for gerrit, especially when the target audience of the software is users that are (or should be) already used to using gerrit.
But for softwares that are very generic and intended to be used widely in larger non Wikimedia/Mediawiki tech communities, folks are not used to gerrit. I don't want to force people to figure out how to create gerrit accounts and create review patches to accept changes from people outside of WMF.
KafkaSSE is a generic library. The EventStreams service codebase (for which KafkaSSE was developed) is in gerrit.
Comment Actions
Are you likely to get many contributors? I've seen this argument many times, and many of these repos receive little to no external commits.
It seems to be me it'd be more worthwhile if someone fixed/maintained the github -> gerrit bot, else just spending time on T37497: Implement a way to bring GitHub pull requests into gerrit more generally
Comment Actions
Are you likely to get many contributors?
You never know! But for KafkaSSE, probably not. :)
Comment Actions
T37497#4860677 - We can install the GitHub plugin (which gerrithub (https://review.gerrithub.io)) uses to pull requests in. So users contribute through GitHub and you pull the requests into gerrit and merge.
Comment Actions
If something like ^ worked nicely, my pro github arguments would be all moot and I'd be fine with gerrit all the way. :)