Page MenuHomePhabricator
Create Task
Maniphest T213222

Recommendation API improvements
Closed, ResolvedPublic
Actions

Description

  • There are some updates in service-template-node. Bring those into the recommendation API repository.
  • Setting up queries in the config is not a good thing to do. These are not configurable parameters, these are a part of the application. These have to be transferred into the code.
  • config.prod.yaml is not needed
  • T210460 - sorry it has not been done in template yet
  • the README is inaccurate. The route to test is not looking as it is written there now, with no MySQL the service will not even operate correctly. I have followed the instructions of the readme to test - one failed.
  • Given that you're hosting the project on Gerrit, .tavis.yaml is not needed
  • There is no CI for the service AFAIK. RelEng should be able to help setting it up - this deserves a subtask.
  • (optional) It would still be interesting to try removing the dependency on WDQS. There's only one query and it doesn't seem impossible to replace with API request and some filtering. Captured here: T216750.
  • The article.creation.morelike - good article title test fails if there's no mysql, so the CI will probably fail too. I would suggest mocking MySQL for that test instead of depending on a real thing.

Details

SubjectRepoBranchLines +/-
Add npm job for recommendation-api serviceintegration/configmaster+18 -0
Add .eslintignoremediawiki/services/recommendation-apimaster+1 -0
Mock MySQL in failing testsmediawiki/services/recommendation-apimaster+75 -10
Remove queires configuration optionmediawiki/services/recommendation-apimaster+82 -160
Remove unneded files and update READMEmediawiki/services/recommendation-apimaster+28 -90
Update to service-template-node v0.5.8mediawiki/services/recommendation-apimaster+56 -104
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 StalledNoneT203041 Output 2.1: An improved task recommendation API
 Resolved• bmansurovT213222 Recommendation API improvements

Event Timeline

• bmansurov triaged this task as High priority.Jan 8 2019, 10:16 PM
• bmansurov created this task.
• Pchelolo lowered the priority of this task from High to Medium.Jan 8 2019, 10:30 PM
• Pchelolo added a project: Services (watching).
• Pchelolo updated the task description. (Show Details)
• Pchelolo added subscribers: • Pchelolo, • mobrovac.
• Pchelolo updated the task description. (Show Details)Jan 8 2019, 10:33 PM
• Pchelolo updated the task description. (Show Details)
gerritbot subscribed.Jan 9 2019, 7:57 PM

Change 483211 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/services/recommendation-api@master] Update to service-template-node v0.5.8

https://gerrit.wikimedia.org/r/483211

gerritbot added a project: Patch-For-Review.Jan 9 2019, 7:57 PM
• bmansurov mentioned this in rMSRAb92469d15951: Update to service-template-node v0.5.8.Jan 9 2019, 7:58 PM
gerritbot added a comment.Jan 9 2019, 7:59 PM

Change 483211 merged by Ppchelko:
[mediawiki/services/recommendation-api@master] Update to service-template-node v0.5.8

https://gerrit.wikimedia.org/r/483211

• Pchelolo updated the task description. (Show Details)Jan 9 2019, 8:00 PM
gerritbot added a comment.Jan 9 2019, 8:15 PM

Change 483218 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/services/recommendation-api@master] Remove unneded files and update README

https://gerrit.wikimedia.org/r/483218

gerritbot added a comment.Jan 9 2019, 8:18 PM

Change 483218 merged by Ppchelko:
[mediawiki/services/recommendation-api@master] Remove unneded files and update README

https://gerrit.wikimedia.org/r/483218

• Pchelolo updated the task description. (Show Details)Jan 9 2019, 8:18 PM
• bmansurov mentioned this in rMSRAc27d0ee553e0: Remove unneded files and update README.Jan 9 2019, 8:22 PM
• Pchelolo updated the task description. (Show Details)Jan 9 2019, 8:29 PM
gerritbot added a comment.Jan 9 2019, 8:45 PM

Change 483225 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[integration/config@master] Add npm job for recommendation-api service

https://gerrit.wikimedia.org/r/483225

• Pchelolo updated the task description. (Show Details)Jan 9 2019, 8:53 PM
gerritbot added a comment.Jan 9 2019, 9:40 PM

Change 483287 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/services/recommendation-api@master] Remove queires configuration optional

https://gerrit.wikimedia.org/r/483287

• bmansurov mentioned this in rMSRA176cf297fba3: Remove queires configuration option.Jan 9 2019, 9:42 PM
• bmansurov mentioned this in rMSRA6ad402166869: Remove queires configuration optional.
• bmansurov moved this task from Backlog to In Progress on the Research board.Jan 9 2019, 9:43 PM
• bmansurov moved this task from Backlog to In Progress on the Recommendation-API board.
• bmansurov edited parent tasks, added: T148129: Productization of Recommendation API; removed: T203041: Output 2.1: An improved task recommendation API.
• bmansurov mentioned this in rMSRAfe4f092033c7: Remove queires configuration option.Jan 10 2019, 2:59 PM
gerritbot added a comment.Jan 10 2019, 6:46 PM

Change 483486 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/services/recommendation-api@master] Mock MySQL in failing tests

https://gerrit.wikimedia.org/r/483486

• bmansurov mentioned this in rMSRA50247319849b: Mock MySQL in failing tests.Jan 10 2019, 6:47 PM
• bmansurov mentioned this in rMSRAea40438439d8: Mock MySQL in failing tests.Jan 10 2019, 7:46 PM
gerritbot added a comment.Jan 10 2019, 7:48 PM

Change 483287 merged by Ppchelko:
[mediawiki/services/recommendation-api@master] Remove queires configuration option

https://gerrit.wikimedia.org/r/483287

gerritbot added a comment.Jan 10 2019, 7:48 PM

Change 483486 merged by Ppchelko:
[mediawiki/services/recommendation-api@master] Mock MySQL in failing tests

https://gerrit.wikimedia.org/r/483486

gerritbot added a comment.Jan 10 2019, 7:56 PM

Change 483503 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/services/recommendation-api@master] Add .eslintignore

https://gerrit.wikimedia.org/r/483503

• bmansurov mentioned this in rMSRA1a1f82429994: Add .eslintignore.Jan 10 2019, 7:59 PM
gerritbot added a comment.Jan 10 2019, 8:02 PM

Change 483503 merged by Ppchelko:
[mediawiki/services/recommendation-api@master] Add .eslintignore

https://gerrit.wikimedia.org/r/483503

• Pchelolo updated the task description. (Show Details)Jan 10 2019, 8:05 PM
• bmansurov added a project: SRE.Jan 11 2019, 5:43 PM
• bmansurov added a subscriber: hashar.

@hashar can you pelase review https://gerrit.wikimedia.org/r/c/integration/config/+/483225

• bmansurov added a project: Release-Engineering-Team.Jan 15 2019, 5:19 PM
leila added a parent task: T203041: Output 2.1: An improved task recommendation API.Jan 15 2019, 7:40 PM
• bmansurov removed a parent task: T148129: Productization of Recommendation API.Jan 17 2019, 7:04 PM
Liuxinyu970226 subscribed.Jan 20 2019, 3:26 PM
• Phabricator_maintenance moved this task from Backlog to Acknowledged on the SRE board.Jan 26 2019, 11:01 PM
gerritbot added a comment.Feb 21 2019, 5:39 PM

Change 483225 merged by jenkins-bot:
[integration/config@master] Add npm job for recommendation-api service

https://gerrit.wikimedia.org/r/483225

• bmansurov updated the task description. (Show Details)Feb 21 2019, 6:15 PM
• bmansurov closed this task as Resolved.Feb 21 2019, 6:18 PM
• bmansurov mentioned this in T216750: Article recommendation API: replace WDQS with MW API.
• bmansurov removed a project: Patch-For-Review.
• bmansurov updated the task description. (Show Details)
• bmansurov moved this task from In Progress to Done on the Recommendation-API board.
• bmansurov moved this task from In Progress to Done (current quarter) on the Research board.
Liuxinyu970226 unsubscribed.Feb 25 2019, 12:54 AM
jijiki mentioned this in rMSRAd6634d36b3bb: Add .eslintignore.Mar 18 2019, 4:37 PM
jijiki mentioned this in rMSRAf039a0436cd8: Mock MySQL in failing tests.
jijiki mentioned this in rMSRAec593ecada2a: Remove queires configuration option.
jijiki mentioned this in rMSRAea0f5fa3d2eb: Remove unneded files and update README.
jijiki mentioned this in rMSRAcd8cd85c4653: Update to service-template-node v0.5.8.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits