Page MenuHomePhabricator
Create Task
Maniphest T213545

Increase readability of the Saved filters box
Open, Needs TriagePublic
Actions

Description

At the moment, the box for Saved filters is narrow. Long filter descriptions are not easy to read, unless you hover them to get a tooltip. The request is to have them readable entirely.

For GSoC 2019, the microtask objectives will be:

  1. limit the max input length for the filter description. We don't have a finalized input length, but we could start with 128 characters and then get feedback
  2. expand the width of the saved filter display. Again we don't have a finalized width, but use your judgement and we can get feedback

Details

SubjectRepoBranchLines +/-
Expanded size of saved filter popup and added character limitmediawiki/coremaster+23 -6
Customize query in gerrit

Related Objects

Event Timeline

Trizek-WMF created this task.Jan 11 2019, 2:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2019, 2:52 PM
Trizek-WMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Jan 11 2019, 2:52 PM
kostajh subscribed.Feb 4 2019, 9:47 PM

image.png (391×1 px, 181 KB)

We might want to also limit the maximum input length for the description.

Timeshifter updated the task description. (Show Details)Feb 5 2019, 10:34 AM
Timeshifter added a comment.Feb 5 2019, 10:40 AM

I want room for a long descriptive title on one wide line. Not a long title spread out over several lines. I want to be able to scan a list of filter set titles. That can be done quickly if each filter set title is on one line. And if there is no need to hover to get the full description.

JTannerWMF moved this task from Needs Discussion to Triaged but Future on the Growth-Team board.Feb 28 2019, 9:12 PM
JTannerWMF added projects: patch-welcome, good first task.
kostajh mentioned this in T219222: Make notification counts update without page reload.Apr 2 2019, 8:27 PM
kostajh updated the task description. (Show Details)Apr 4 2019, 7:58 PM
gerritbot added a comment.Nov 15 2019, 12:05 PM

Change 551160 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/core@master] Expanded size of saved filter popup and added character limit

https://gerrit.wikimedia.org/r/551160

gerritbot added a project: Patch-For-Review.Nov 15 2019, 12:05 PM
Soda claimed this task.Nov 15 2019, 12:05 PM
Trizek-WMF moved this task from Triaged but Future to Needs Discussion on the Growth-Team board.Nov 15 2019, 3:43 PM
Soda added a comment.Nov 15 2019, 4:39 PM

While fiddling around the interface, I found that the title element does not update when the filter is renamed.. Should I file a separate task for this bug ?

Screenshot from 2019-11-15 22-06-30.png (768×1 px, 110 KB)

gerritbot added a comment.Dec 4 2019, 4:05 PM

Change 551160 abandoned by Sohom Datta:
Expanded size of saved filter popup and added character limit

Reason:
Nah, too many errors, I should probably be doing this from inside the model itself and then adding constrains to the UI

https://gerrit.wikimedia.org/r/551160

Soda removed Soda as the assignee of this task.Dec 4 2019, 4:06 PM
Soda subscribed.
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM
Pppery removed a project: Patch-For-Review.Apr 1 2023, 7:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL