Page MenuHomePhabricator

Reduce .wikitable selector specificity
Open, Needs TriagePublic

Description

.wikitable specificity was increased due to T32485: Hieroglyphs look scary if embedded in tables with class="wikitable" and T35434: math extension: integral expressions display with boxes/frames/borders, but I couldn't find need of table.wikitable in current testing of pages described back then. The direct child selectors > seem sufficient on their own.

Let's remove table part as

  • it makes styling overrides unnecessary more complex
  • overqualifying selector by HTML element is seen as bad practices (class could be reused with other elements)
  • it is nowhere used apart form a table element in known projects to us
  • adds extra bytes sent to client

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2019, 12:14 AM

Change 485344 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Reduce selector specificity of .wikitable

https://gerrit.wikimedia.org/r/485344

Change 485344 merged by jenkins-bot:
[mediawiki/core@master] Reduce selector specificity of .wikitable

https://gerrit.wikimedia.org/r/485344

Change 485352 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Reduce unnecessary selector specificity

https://gerrit.wikimedia.org/r/485352

Change 485353 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/Timeless@master] Reduce unnecessary selector specificity

https://gerrit.wikimedia.org/r/485353

Change 485353 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Reduce unnecessary selector specificity

https://gerrit.wikimedia.org/r/485353

Change 485356 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Replace sorting classes with better naming convention

https://gerrit.wikimedia.org/r/485356

Change 485352 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Reduce unnecessary selector specificity

https://gerrit.wikimedia.org/r/485352

Change 485516 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Replace 'TablePager' class exclusively by mw-datatable

https://gerrit.wikimedia.org/r/485516

Change 485356 merged by jenkins-bot:
[mediawiki/core@master] Replace sorting classes with better naming convention

https://gerrit.wikimedia.org/r/485356

Change 485516 merged by jenkins-bot:
[mediawiki/core@master] Replace 'TablePager' CSS class exclusively by mw-datatable

https://gerrit.wikimedia.org/r/485516