Gallery media is erroneously using sub-typeof if format is supplied
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Arlolra
	Jan 24 2019, 4:51 PM

Description

For example,

<gallery>
Test.jpg|thumb|123
</gallery>

yields,

... <figure-inline typeof="mw:Image/Thumb"> ...

where "thumb" should be ignored.

Maybe move up the "none" we place at the end so that subsequent formats become bogus,
https://github.com/wikimedia/parsoid/blob/master/lib/ext/Gallery/index.js#L145 This would change in T305628 but, regardless, "none" is not a format

Or, strip it before transferring,
https://github.com/wikimedia/parsoid/blob/master/lib/ext/Gallery/modes.js#L120

Details

Subject	Repo	Branch	Lines +/-
Bump parsoid to 0.18.0-a6	mediawiki/vendor	master	+186 -73
Suppress media formats when used on a gallery line	mediawiki/services/parsoid	master	+49 -19
Bump parsoid to 0.16.0-a14	mediawiki/vendor	master	+851 -828
Account for format being in gallery media options	mediawiki/services/parsoid	master	+19 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Arlolra	T252246 Borrow functionality from the LinkHandlerUtils::figureHandler for serializing media in gallery
		Resolved		Arlolra	T214601 Gallery media is erroneously using sub-typeof if format is supplied

Event Timeline

Arlolra created this task.Jan 24 2019, 4:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2019, 4:51 PM

Roundtripping the bogus option would be part of T211895 / T151367

In "plwiki/Leonardo da Vinci", the dimensions gets applied, which is similar,

Leonardo machines.JPG|thumb|150px|Różne urządzenia hydrauliczne.

• ssastry triaged this task as Medium priority.Jun 10 2019, 8:53 PM

• ssastry moved this task from Needs Triage to Link syntax (links & media) on the Parsoid board.

• ssastry moved this task from Link syntax (links & media) to Bugs & Crashers on the Parsoid board.Feb 28 2020, 5:09 PM

Arlolra added a parent task: T252246: Borrow functionality from the LinkHandlerUtils::figureHandler for serializing media in gallery.May 8 2020, 8:36 PM

Arlolra mentioned this in T290044: Allow inline imagemaps.Aug 31 2021, 2:44 AM

Arlolra mentioned this in T275074: Gallery does not allow lowercase "center" "left" or "right" as a caption for a gallery image.Nov 22 2021, 10:30 PM

Jonesey95 subscribed.Nov 22 2021, 10:37 PM

Arlolra updated the task description. (Show Details)Jun 9 2022, 9:13 PM

Change 804459 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Account for format being in gallery media options

https://gerrit.wikimedia.org/r/804459

gerritbot added a project: Patch-For-Review.Jun 9 2022, 9:58 PM

Arlolra claimed this task.Jun 9 2022, 9:58 PM

Arlolra added a project: Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure).

Arlolra moved this task from Backlog to Code Review on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.

Arlolra moved this task from Code Review to To Deploy on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Jun 14 2022, 6:39 PM

Change 804459 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Account for format being in gallery media options

https://gerrit.wikimedia.org/r/804459

Maintenance_bot removed a project: Patch-For-Review.Jun 22 2022, 11:30 PM

Change 808051 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a14

https://gerrit.wikimedia.org/r/808051

gerritbot added a project: Patch-For-Review.Jun 23 2022, 6:53 PM

Change 808051 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a14

https://gerrit.wikimedia.org/r/808051

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2022, 9:31 PM

Arlolra moved this task from To Deploy to To Verify on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Jun 28 2022, 5:33 PM

Arlolra closed this task as Resolved.Jun 28 2022, 9:26 PM

Arlolra mentioned this in T333907: Address semantic differences from enabling nativeGalleryEnabled.Apr 4 2023, 12:14 AM

Change 909340 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Suppress media formats when used on a gallery line

https://gerrit.wikimedia.org/r/909340

gerritbot added a project: Patch-For-Review.Apr 18 2023, 1:40 PM

Change 909340 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Suppress media formats when used on a gallery line

https://gerrit.wikimedia.org/r/909340

Maintenance_bot removed a project: Patch-For-Review.Apr 18 2023, 6:27 PM

Change 911253 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump parsoid to 0.18.0-a6

https://gerrit.wikimedia.org/r/911253

gerritbot added a project: Patch-For-Review.Apr 24 2023, 8:43 AM

Change 911253 merged by jenkins-bot: