Page MenuHomePhabricator
Create Task
Maniphest T216267

"Broken images" not working on mobile VE
Closed, ResolvedPublic
Actions

Description

A broken image is one where the target file no longer exists (e.g. has been deleted). These render as framed redlinks in MediaWiki.

The layout in mobile VE is broken:

image.png (397×417 px, 12 KB)

Details

SubjectRepoBranchLines +/-
Don't try to set dimensions on an error imagemediawiki/extensions/VisualEditormaster+6 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Feb 15 2019, 6:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2019, 6:30 PM
gerritbot subscribed.Feb 15 2019, 6:30 PM

Change 490898 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Don't try to set dimensions on an error image

https://gerrit.wikimedia.org/r/490898

gerritbot added a project: Patch-For-Review.Feb 15 2019, 6:30 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Feb 15 2019, 6:30 PM
Jdforrester-WMF moved this task from Code review to QA on the VisualEditor (Current work) board.Feb 15 2019, 6:48 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Feb 15 2019, 7:01 PM

Change 490898 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Don't try to set dimensions on an error image

https://gerrit.wikimedia.org/r/490898

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.18; 2019-02-19).Feb 15 2019, 8:01 PM
Esanders added a project: Editing QA.Feb 18 2019, 8:51 PM
• Whatamidoing-WMF mentioned this in T216648: Can't cut, copy, or delete templates (probably all similar nodes) in mobile-visual editor from the keyboard.Feb 20 2019, 7:24 PM
Esanders moved this task from Inbox to Low Priority on the Editing QA board.Feb 20 2019, 7:31 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Feb 22 2019, 11:35 PM
Ryasmeen added a project: Editing QA.Feb 26 2019, 8:46 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Feb 27 2019, 6:55 PM
Ryasmeen removed a project: Editing QA.Feb 28 2019, 10:39 PM
ppelberg closed this task as Resolved.Feb 28 2019, 11:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL