Page MenuHomePhabricator
Create Task
Maniphest T216580

[wmf.18-regression] Flow page - 'Reply' switches to no js mode
Closed, ResolvedPublic
Actions

Description

  1. In testwiki or mediawiki go to a Flow page and click on 'Reply' under any post.

The Console error will be briefly displayed:

Uncaught TypeError: $existingWidget.data(...).trigger is not a function
  at HTMLAnchorElement.<anonymous>
  at HTMLDiveElement.dispatch
  at HTMLDivElement.elemData.handle
  1. A user gets redirected to a permalink and the nojs mode will be displayed for the Reply area will be displayed.

nojs_Reply.gif (724×1 px, 1 MB)

  1. If a text area for a Reply is clicked, the behavior is as usual.

Details

SubjectRepoBranchLines +/-
Unbreak reply clicks with existing widgetmediawiki/extensions/Flowwmf/1.33.0-wmf.18+4 -2
Unbreak reply clicks with existing widgetmediawiki/extensions/Flowmaster+4 -2
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Feb 20 2019, 12:39 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 20 2019, 12:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
SBisson subscribed.Feb 20 2019, 12:51 AM

The line that break was changed by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/486999/

Catrope subscribed.Feb 20 2019, 2:31 AM
In T216580#4967341, @SBisson wrote:

The line that break was changed by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/486999/

Thanks for your comment on the Gerrit change, I'm pretty sure that's exactly it.

gerritbot subscribed.Feb 20 2019, 2:36 AM

Change 491670 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Flow@master] Unbreak reply clicks with existing widget

https://gerrit.wikimedia.org/r/491670

gerritbot added a project: Patch-For-Review.Feb 20 2019, 2:36 AM
Catrope claimed this task.Feb 20 2019, 2:37 AM
Catrope edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Catrope moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Feb 20 2019, 10:28 AM

Change 491670 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Unbreak reply clicks with existing widget

https://gerrit.wikimedia.org/r/491670

Trizek-WMF subscribed.Feb 20 2019, 10:59 AM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.19; 2019-02-26).Feb 20 2019, 11:00 AM
SBisson added a comment.Feb 20 2019, 11:21 AM

I think we should SWAT this fix. I can do it at noon (EST) today if there's no objections.

gerritbot added a comment.Feb 20 2019, 1:20 PM

Change 491744 had a related patch set uploaded (by Sbisson; owner: Catrope):
[mediawiki/extensions/Flow@wmf/1.33.0-wmf.18] Unbreak reply clicks with existing widget

https://gerrit.wikimedia.org/r/491744

gerritbot added a comment.Feb 20 2019, 5:17 PM

Change 491744 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.33.0-wmf.18] Unbreak reply clicks with existing widget

https://gerrit.wikimedia.org/r/491744

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.18; 2019-02-19); removed MW-1.33-notes (1.33.0-wmf.19; 2019-02-26).Feb 20 2019, 6:00 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 20 2019, 6:19 PM
Etonkovidova closed this task as Resolved.Feb 20 2019, 9:34 PM

Checked in wmf.18.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits