Page MenuHomePhabricator

Visual Editor educational popup about links has LTR and RTL versions of the image in reverse
Closed, ResolvedPublic

Description

When assessing English Wikipedia in in-cognito mode (to simulate that it's the first time I access VE), a pulsing blue dot over the link tool allows to access a popup. There the illustration shown uses elements with an RTL layout (note the Wikipedia sidebar on the right):

Inspecting the LTR and RTL versions of the images, it seems they are swapped currently.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2019, 2:36 PM

Change 492253 had a related patch set uploaded (by Setian; owner: Setian):
[mediawiki/extensions/VisualEditor@master] Swap the link-rtl.png and link-ltr.png files

https://gerrit.wikimedia.org/r/492253

Just curious, is the RTL version actually used anywhere? I ran a Catfish search and didn't see it in any of the files, although the LTR version is used in VisualEditor/modules/ve-mw/ui/styles/tools/ve.ui.MWLinkInspectorTool.css

Just curious, is the RTL version actually used anywhere? I ran a Catfish search and didn't see it in any of the files, although the LTR version is used in VisualEditor/modules/ve-mw/ui/styles/tools/ve.ui.MWLinkInspectorTool.css

I think CSS Janus is in charge of delivering the correct version depending on the language direction. You can check Hebrew Wikipedia to see how the image is mirrored with respect to the one in the description:

Funny, they have been swapped ever since we added them in 2015… https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/238380

Thanks for the patch!

matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.

Change 492253 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Swap the link-rtl.png and link-ltr.png files

https://gerrit.wikimedia.org/r/492253

ppelberg closed this task as Resolved.Mar 14 2019, 10:47 PM
ppelberg claimed this task.