There is no need to show an item in a diff, when there is no change to it. Please show only items with a difference, so the user can easilier catch all necessary information. Thanks.
The problem related on bug 20851 has been seen by me a couple of days ago. As I'm not sure if that bug is really a duplicate from this bug, I guess I should report it here too:
Please, compare the value of added_lines and removed_lines variables with the
actual diff on this case:
- Actual diff:
What I've found particulary odd was that this problem occured only with some
edits, and mostly with bots edits, although at time the code wasn't filtering
by user group (I've even added a user group condition, thinking at first this
could be the problem, though it not seems the case now).
If bug 20851 is indeed a duplicate of this bug, I'm sorry.
Maybe it's related to line feeds. Let them be visible below:
" is removed and "
" is added. We may want to add trailing line feeds when calculating diff variables.
I'm not sure, but is this related to diffs between two version of a filter? And, if I understood right, the proposal is not to show unchanged elements at all, instead of graying them? If so, it would be easy to do, but the diff could become terribly short and will miss some context. I'm not sure whether this is desired.
AbuseFilter diffs should behave more like Wikidata diffs. Compare these: