Page MenuHomePhabricator
Create Task
Maniphest T217672

Use baserevid in Forms editing
Closed, ResolvedPublic
Actions

Description

Same AC in parent ticket

Details

SubjectRepoBranchLines +/-
Use baserevid in Forms editingmediawiki/extensions/WikibaseLexememaster+23 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alaa_wmde created this task.Mar 5 2019, 4:26 PM
Addshore triaged this task as Medium priority.Mar 5 2019, 4:27 PM
gerritbot subscribed.Mar 19 2019, 3:24 PM

Change 497515 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Use baserevid in Forms editing

https://gerrit.wikimedia.org/r/497515

gerritbot added a project: Patch-For-Review.Mar 19 2019, 3:24 PM
Ladsgroup claimed this task.Mar 19 2019, 4:35 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMar 19 2019, 4:35 PM
Ladsgroup mentioned this in rEWLE0e8053798d41: Use baserevid in Forms editing.Mar 21 2019, 12:41 AM
Ladsgroup mentioned this in rEWLE40be3e17a9f5: Use baserevid in Forms editing.
Ladsgroup mentioned this in rEWLE0eb3e27dfcff: Use baserevid in Forms editing.
Ladsgroup mentioned this in rEWLEdcf0580e9f7d: Use baserevid in Forms editing.
Addshore mentioned this in rEWLE886734459efe: Use baserevid in Forms editing.Mar 27 2019, 10:21 AM
• alaa_wmde added a comment.Mar 27 2019, 4:49 PM

This cane be merged even before https://phabricator.wikimedia.org/T218115 right?

noarave moved this task from Peer Review to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 12 2019, 10:03 AM
Ladsgroup moved this task from Stalled/Waiting to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 8 2019, 11:56 AM
In T217672#5062796, @alaa_wmde wrote:

This cane be merged even before https://phabricator.wikimedia.org/T218115 right?

Not can but actually should, given that js modules are cached in client, requiring baserevid at the same time than using it on UI will cause mayhem.

Ladsgroup added a comment.May 8 2019, 11:58 AM

I recommend these two patches go one branch before the requiring the parameter in API

Ladsgroup mentioned this in rEWLE21f738b298c6: Use baserevid in Forms editing.May 8 2019, 3:02 PM
Ladsgroup mentioned this in rEWLE55b63a99feea: Use baserevid in Forms editing.May 13 2019, 12:04 PM
Ladsgroup mentioned this in rEWLE771eb2357347: Use baserevid in Forms editing.May 13 2019, 12:14 PM
Michael subscribed.May 13 2019, 3:21 PM

This patch doesn't go well with that strange error message from 508851:

image.png (308×1 px, 35 KB)

Ladsgroup added a comment.May 13 2019, 8:23 PM
In T217672#5177083, @Michael wrote:

This patch doesn't go well with that strange error message from 508851:

image.png (308×1 px, 35 KB)

After fighting the tests really hard, I finally was able to fix it: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/509933

Ladsgroup mentioned this in rEWLE8564c2223408: Send the patched lexeme based on the baserevid sent in wbladdform.May 13 2019, 8:25 PM
Ladsgroup mentioned this in rEWLE3c1075918049: Send the patched lexeme based on the baserevid sent in wbladdform.May 14 2019, 12:29 PM
Ladsgroup mentioned this in rEWLE4d23ef362cec: Use baserevid in Forms editing.
Michael mentioned this in rEWLE885a8deb26b6: Send the patched lexeme based on the baserevid sent in wbladdform.May 15 2019, 3:41 PM
Michael mentioned this in rEWLEc5dc5e2f222e: Use baserevid in Forms editing.
WMDE-leszek moved this task from Peer Review to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 27 2019, 1:45 PM
WMDE-leszek subscribed.

Requires the issue reported in T223207 to be fixed first.

Addshore moved this task from incoming to in progress on the Wikidata board.Jun 21 2019, 11:28 PM
Ladsgroup closed subtask T223207: After aplying baserevid to add form, it's impossible to add two forms without refresh as Invalid.Jul 4 2019, 10:55 AM
Ladsgroup moved this task from Stalled/Waiting to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Updated the patch so it doesn't try to send baserevid in adding form or sense.

• alaa_wmde moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 8 2019, 4:00 PM
gerritbot added a comment.Jul 8 2019, 4:17 PM

Change 497515 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use baserevid in Forms editing

https://gerrit.wikimedia.org/r/497515

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 8 2019, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 8 2019, 5:10 PM
Rosalie_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 26 2019, 6:04 AM
• alaa_wmde closed this task as Resolved.Oct 1 2019, 2:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits