Ability to disable user-specific SSR
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

In order to allow for smooth deployment and easier debugging it would be beneficial to be able to control in which scenarios requests against the newly introduced SSR service are performed. This is particularly important as results of the requests for user-specific termbox markup are not cached/hardly cachable.

AC:

there exists a config variable "termboxUserSpecificSsrEnabled" to Enable/Disable server-side rendering (SSR) for user-specific termbox markup. The default setting is <code>true</code>. It only comes into effect if the general "termboxEnabled" is <code>true</code>. If disabled, user-specific termbox markup will only be created by client-side rendering after initial diplaying of the generic termbox markup. See termboxEnabled
requests that are not user-specific (or "default" requests) are performed as usual to provide basic server-side rendering. Only re-rendering for user-specific markup can be disabled with the newly introduced config variable. See https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/master/repo/includes/ParserOutput/PlaceholderExpander/ExternallyRenderedEntityViewPlaceholderExpander.php#65

Details

	Subject	Repo	Branch	Lines +/-
	Get ability to disable user-specific SSR	mediawiki/extensions/Wikibase	master	+39 -4

Customize query in gerrit

Event Timeline

• Pablo-WMDE created this task.Mar 12 2019, 10:47 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2019, 10:47 AM

• Pablo-WMDE moved this task from Backlog to MVP things: Ready for pickup on the Wikidata-Termbox board.Mar 12 2019, 3:20 PM

Users with specialized data are not cached. If we need to reduce the number of requests, not ever sending SSR requests in those cases (i.e. showing nothing), but forcing users to wait for the client side action to kick in would be an option.
If we don't have this, and run into problems with the number of requests, the only way to reduce the number of requests would be disabling the new termbox functionality completely, falling back to the current state.

• Lea_WMDE moved this task from MVP things: Ready for pickup to Editing (deprioritized tickets) on the Wikidata-Termbox board.Mar 13 2019, 4:09 PM

Lydia_Pintscher added a project: Wikidata.Mar 19 2019, 7:41 PM

Addshore moved this task from incoming to in progress on the Wikidata board.Mar 25 2019, 4:04 PM

• Lea_WMDE moved this task from Editing (deprioritized tickets) to Tech (deprioritized tickets) on the Wikidata-Termbox board.Apr 12 2019, 11:36 AM

Change 508991 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] Get ability to disable user-specific SSR

https://gerrit.wikimedia.org/r/508991

gerritbot added a project: Patch-For-Review.May 9 2019, 7:40 AM

• Matthias_Geisler_WMDE claimed this task.May 9 2019, 10:00 AM

• Matthias_Geisler_WMDE edited projects, added Wikidata-Termbox-Iteration-15; removed Wikidata-Termbox.

• Matthias_Geisler_WMDE moved this task from To Do to Peer Review on the Wikidata-Termbox-Iteration-15 board.

Jakob_WMDE moved this task from Peer Review to To Do on the Wikidata-Termbox-Iteration-15 board.May 10 2019, 3:08 PM

Jakob_WMDE updated the task description. (Show Details)May 10 2019, 3:19 PM

• Matthias_Geisler_WMDE moved this task from To Do to Peer Review on the Wikidata-Termbox-Iteration-15 board.May 14 2019, 9:42 AM

WMDE-leszek added a project: Wikidata-Termbox-Iteration-16.May 20 2019, 10:35 AM

WMDE-leszek moved this task from To Do to Test (Product Review) on the Wikidata-Termbox-Iteration-16 board.

WMDE-leszek moved this task from Test (Product Review) to Peer Review on the Wikidata-Termbox-Iteration-16 board.

Change 508991 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Get ability to disable user-specific SSR