Page MenuHomePhabricator

Alignment of Search help text is off when switching between modes (Alpha/Labs)
Open, NormalPublicBug

Description

User story: N/A

We have this:
Keyword mode help text looks right, but Depicts (soon to be called Tabs T218431) is a little further to the right.

We want this:
Depicts/Tags help text should match the left-aligned position that Keyword help text has.

Screenshots (if possible):


Acceptance Criteria:

  • Help text for Depicts/Tags matches help text for Keyword search

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2019, 8:40 PM

Unfortunately, this is not a bug, but a side-effect of using 2 different input methods (plain input for keywords, and capsules for depict)
See @Volker_E's comment in another ticket about this subject (and a few other issues)

And now that work on search is coming back, we need to look into that ticket and see what things can be fixed, and what we do with the rest :) (I'll try to do so this week)

From a conversation with @PDrouin-WMF off-Phab:

The reason for the placeholder to feature more padding-left is that when you enter the tag the label turns flawlessly into a tag without movement https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop#TagMultiselectWidget-allowArbitrary-inline-input-placeholder
I'd consider removing the indentation alignment in your special case, and add the padding as soon as a value/tag is entered

matthiasmullie removed matthiasmullie as the assignee of this task.May 21 2019, 11:25 AM
Restricted Application added a project: Multimedia. · View Herald TranscriptSat, Aug 10, 11:55 PM