Page MenuHomePhabricator
Create Task
Maniphest T218431

[Alpha/Labs] Basic Search labels + help text need updating
Closed, ResolvedPublic
Actions

Description

Context

Design will be testing the search prototype on Alpha/Labs (relevant ticket: T216774) ideally by March 19th or 20th. Link: https://federated-commons.wmflabs.org/wiki/Main_Page

We have this copy for Basic search:

(Label | Help text)
Keyword | Search by keyword
Depicts | Search by depicted items

We want this instead:

Keyword | Find media files using keywords in titles and descriptions
Tags | Find media files using tags that represent concepts or topics

Acceptance Criteria:

  • Search input mode toggle shows "Keyword" and "Tags" (instead of "Keyword" and "Depicts")
  • Input field placeholder text for "Keyword" mode is: "Search in titles and descriptions"
  • Input field placeholder text for "Tags" mode is: "Search concepts or topics"

Details

SubjectRepoBranchLines +/-
Search prototypemediawiki/extensions/WikibaseMediaInfomaster+1 K -14
Customize query in gerrit

Related Objects

Event Timeline

• PDrouin-WMF created this task.Mar 15 2019, 8:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2019, 8:03 PM
• PDrouin-WMF changed the subtype of this task from "Bug Report" to "Task".Mar 15 2019, 8:15 PM
• Ramsey-WMF triaged this task as Medium priority.Mar 15 2019, 8:31 PM
• Ramsey-WMF added projects: Structured Data Engineering, Structured-Data-Team-Current-Work.
• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.
• Ramsey-WMF added a subscriber: matthiasmullie.

Pinging @matthiasmullie on this one to see if he can knock it out quickly on Monday ;)

• PDrouin-WMF mentioned this in T218435: Alignment of Search help text is off when switching between modes (Alpha/Labs) .Mar 15 2019, 8:40 PM
matthiasmullie claimed this task.Mar 18 2019, 11:05 AM
gerritbot subscribed.Mar 18 2019, 11:05 AM

Change 441040 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Search prototype

https://gerrit.wikimedia.org/r/441040

gerritbot added a project: Patch-For-Review.Mar 18 2019, 11:05 AM
matthiasmullie mentioned this in rEWBI38dc1ca1e3b2: Search prototype.Mar 18 2019, 11:05 AM
matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.Mar 18 2019, 11:05 AM
matthiasmullie mentioned this in rEWBI4fdf7d57c287: Search prototype.Mar 18 2019, 11:15 AM
matthiasmullie mentioned this in rEWBI6fd13c38df33: Search prototype.Mar 18 2019, 11:35 AM
• PDrouin-WMF added a comment.EditedMar 18 2019, 2:35 PM

@matthiasmullie unfortunately the default OOUI text size is causing the help text to running past the width of the search box for tags. We'll need to update again before testing with users with even shorter help text:

Search in titles and descriptions
Search concepts or topics

matthiasmullie mentioned this in rEWBI810e044919ff: Search prototype.Mar 18 2019, 4:00 PM
gerritbot added a comment.Mar 19 2019, 1:42 PM

Change 441040 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Search prototype

https://gerrit.wikimedia.org/r/441040

• PDrouin-WMF renamed this task from Basic Search labels + help text need updating on Alpha/Labs to [Alpha/Labs] Basic Search labels + help text need updating .Mar 19 2019, 3:34 PM
• Ramsey-WMF moved this task from To Do to Doing on the Structured Data Engineering board.Mar 19 2019, 6:05 PM
matthiasmullie mentioned this in rEWBI628ec6fb63ab: Search prototype.Mar 21 2019, 12:23 AM
matthiasmullie mentioned this in rEWBI71b81f98b4e6: Search prototype.
matthiasmullie mentioned this in rEWBI4f20379e90a6: Search prototype.
matthiasmullie mentioned this in rEWBI9fbbee31916c: Search prototype.
matthiasmullie mentioned this in rEWBI1e53fa909b02: Search prototype.
matthiasmullie mentioned this in rEWBI929b5fc8b155: Search prototype.
matthiasmullie mentioned this in rEWBIf00fc630f5bf: Search prototype.
matthiasmullie mentioned this in rEWBIdf4e9bcf2b0a: Search prototype.
gerritbot added a comment.Mar 21 2019, 12:00 PM

Change 441040 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Search prototype

https://gerrit.wikimedia.org/r/441040

Cparle moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.Mar 21 2019, 12:08 PM
matthiasmullie updated the task description. (Show Details)Mar 28 2019, 9:29 AM
matthiasmullie updated the task description. (Show Details)
matthiasmullie mentioned this in T208791: In the search bar, vary the placeholder text for each search mode (keyword/depict/other statements).Mar 28 2019, 9:34 AM
matthiasmullie reassigned this task from matthiasmullie to Edtadros.Mar 28 2019, 9:48 AM
Edtadros reassigned this task from Edtadros to matthiasmullie.Mar 30 2019, 4:02 PM
Edtadros subscribed.

@matthiasmullie I believe I can make out the test steps from the Acceptance Criteria. Can you let me know what environment (URL would be helpful) I should be testing this in?

• Ramsey-WMF updated the task description. (Show Details)Apr 1 2019, 8:37 PM

@Edtadros I added the URL to Alpha/Labs/Federated Commons in the task description.

• Ramsey-WMF reassigned this task from matthiasmullie to Edtadros.Apr 1 2019, 8:44 PM
Cparle edited projects, added SDC-Statements (Depicts-on-training-wheels); removed SDC-Statements (Depicts-Crawling).Apr 17 2019, 2:08 PM
Cparle closed this task as Resolved.Apr 17 2019, 2:10 PM
Cparle removed Edtadros as the assignee of this task.
Cparle updated the task description. (Show Details)
Cparle subscribed.

This ticket was some updates that needed to be made in advance of user testing. User testing is done now, so closing

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits