Page MenuHomePhabricator
Create Task
Maniphest T208791

In the search bar, vary the placeholder text for each search mode (keyword/depict/other statements)
Closed, ResolvedPublic
Actions

Description

Add placeholder text to search field modes (search placeholder text should work like Wikipedia’s, retaining the placeholder text when the search bar is selected, and disappearing when the user begins typing, and reappearing, should the user delete any typed characters).

  • Keywords: Search by keyword
  • Depicts: Search by depicted items
  • Other statements: Search by other statements

Screenshot 2018-11-05 16.02.34.png (1×1 px, 178 KB)

Details

SubjectRepoBranchLines +/-
Search prototypemediawiki/extensions/WikibaseMediaInfomaster+1 K -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

• PDrouin-WMF created this task.Nov 5 2018, 9:05 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptNov 5 2018, 9:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Ramsey-WMF triaged this task as Medium priority.Nov 13 2018, 1:31 AM
• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.
gerritbot subscribed.Dec 13 2018, 4:17 PM

Change 441040 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Search prototype

https://gerrit.wikimedia.org/r/441040

gerritbot added a project: Patch-For-Review.Dec 13 2018, 4:17 PM
matthiasmullie mentioned this in rEWBIf49a57e66991: Search prototype.Dec 13 2018, 4:17 PM
matthiasmullie mentioned this in rEWBI0114d1ec3cd8: Search prototype.Dec 17 2018, 1:53 PM
matthiasmullie mentioned this in rEWBI5584a2a5b021: Search prototype.Jan 2 2019, 12:20 PM
matthiasmullie mentioned this in rEWBIc7a9c401d88d: Search prototype.Jan 2 2019, 12:34 PM
matthiasmullie mentioned this in rEWBI27a639eea6bd: Search prototype.Jan 2 2019, 4:00 PM
matthiasmullie mentioned this in rEWBI167bbc7b0218: Search prototype.Jan 7 2019, 10:23 AM
matthiasmullie mentioned this in rEWBIfb6135afb021: Search prototype.Jan 7 2019, 10:47 AM
matthiasmullie mentioned this in rEWBI55e6a1ff10a3: Search prototype.Jan 7 2019, 11:31 AM
matthiasmullie mentioned this in rEWBIe45a8604525d: Search prototype.Jan 7 2019, 11:59 AM
Jdforrester-WMF added a parent task: T199352: Deploy Structured Data on Commons with arbitrary Statements.Jan 10 2019, 5:55 PM
matthiasmullie mentioned this in rEWBI049e631c36c7: Search prototype.Jan 10 2019, 6:23 PM
matthiasmullie mentioned this in rEWBIbbda7a9bc768: Search prototype.Jan 14 2019, 5:01 PM
matthiasmullie mentioned this in rEWBI1bae3feaaef6: Search prototype.Jan 15 2019, 4:17 PM
matthiasmullie mentioned this in rEWBI2537496a27a4: Search prototype.Jan 16 2019, 3:05 PM
matthiasmullie mentioned this in rEWBI3e7990197255: Search prototype.Jan 16 2019, 5:25 PM
Jdforrester-WMF renamed this task from Search bar placeholder text for each kind of search mode to In the search bar, vary the placeholder text for each search mode (keyword/depict/other statements.Feb 5 2019, 6:01 PM
Jdforrester-WMF renamed this task from In the search bar, vary the placeholder text for each search mode (keyword/depict/other statements to In the search bar, vary the placeholder text for each search mode (keyword/depict/other statements).Feb 5 2019, 6:05 PM
Jdforrester-WMF edited parent tasks, added: T212262: [Spike] Can we use existing OOUI multi-select dropdown?; removed: T199352: Deploy Structured Data on Commons with arbitrary Statements.Feb 5 2019, 7:26 PM
matthiasmullie mentioned this in rEWBI82c2d1f2dc90: [WIP] Search prototype.Feb 28 2019, 2:22 PM
MarkTraceur added a project: Structured Data Engineering (Depicts and other statements on a bicycle).Mar 1 2019, 4:19 PM
• Phabricator_maintenance added a project: SDC-Statements (Depicts-on-training-wheels).Mar 7 2019, 12:31 AM
matthiasmullie mentioned this in rEWBI89f05f6c1619: [WIP] Search prototype.Mar 7 2019, 5:21 PM
matthiasmullie mentioned this in rEWBI6f357d2e5ff7: [WIP] Search prototype.Mar 8 2019, 3:42 PM
matthiasmullie mentioned this in rEWBI8dfab8e30038: [WIP] Search prototype.Mar 8 2019, 5:13 PM
matthiasmullie mentioned this in rEWBI1eaaa887e07e: [WIP] Search prototype.Mar 8 2019, 7:38 PM
matthiasmullie mentioned this in rEWBI083440765be8: [WIP] Search prototype.Mar 8 2019, 7:42 PM
matthiasmullie mentioned this in rEWBIbec0bca7a378: Search prototype.Mar 12 2019, 11:39 AM
matthiasmullie claimed this task.Mar 12 2019, 12:00 PM
matthiasmullie added a project: Structured-Data-Team-Current-Work.
matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.Mar 12 2019, 12:02 PM
matthiasmullie mentioned this in rEWBIbc9944b4e074: Search prototype.Mar 13 2019, 3:59 PM
matthiasmullie mentioned this in rEWBIf72d12606a03: Search prototype.Mar 14 2019, 10:04 AM
matthiasmullie mentioned this in rEWBId56946fa2ce1: Search prototype.Mar 14 2019, 12:51 PM
matthiasmullie mentioned this in rEWBIbfd45d50a71e: Search prototype.Mar 14 2019, 3:24 PM
matthiasmullie mentioned this in rEWBI38dc1ca1e3b2: Search prototype.Mar 18 2019, 11:05 AM
matthiasmullie mentioned this in rEWBI4fdf7d57c287: Search prototype.Mar 18 2019, 11:15 AM
matthiasmullie mentioned this in rEWBI6fd13c38df33: Search prototype.Mar 18 2019, 11:35 AM
matthiasmullie mentioned this in rEWBI810e044919ff: Search prototype.Mar 18 2019, 4:00 PM
gerritbot added a comment.Mar 19 2019, 1:42 PM

Change 441040 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Search prototype

https://gerrit.wikimedia.org/r/441040

matthiasmullie mentioned this in rEWBI628ec6fb63ab: Search prototype.Mar 21 2019, 12:23 AM
matthiasmullie mentioned this in rEWBI71b81f98b4e6: Search prototype.
matthiasmullie mentioned this in rEWBI4f20379e90a6: Search prototype.
matthiasmullie mentioned this in rEWBI9fbbee31916c: Search prototype.
matthiasmullie mentioned this in rEWBI1e53fa909b02: Search prototype.
matthiasmullie mentioned this in rEWBI929b5fc8b155: Search prototype.
matthiasmullie mentioned this in rEWBIf00fc630f5bf: Search prototype.
matthiasmullie mentioned this in rEWBIdf4e9bcf2b0a: Search prototype.
gerritbot added a comment.Mar 21 2019, 12:00 PM

Change 441040 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Search prototype

https://gerrit.wikimedia.org/r/441040

Cparle moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.Mar 21 2019, 12:09 PM
matthiasmullie closed this task as Resolved.Mar 28 2019, 9:34 AM

Patch has been merged.
Functionality will be tested in T199120
Copy has been changed in T218431
Nothing left to QA or sign off here that is not already covered elsewhere.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits