In mobile VE, using the "Format" menu causes the page to scroll up by ~half the screen every time. Only tested on iOS so far, no idea what causes this and if it may affect other devices.
Video: https://drive.google.com/file/d/1NXZkJwQBW_IvD6ZZAuwBj-DbcBoXZMBk/view (too large for Phabricator)
I thought this may be related to T218635, but the patch for that bug does not fix it.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | matmarex | T218635 Mobile visual editor scrolls to the top of the page after adding a link in iOS Safari | |||
| Resolved | ppelberg | T218650 In mobile VE, using the "Format" menu causes the page to scroll up by ~half the screen every time (iOS only?) |
Change 498650 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.Surface: Maybe fix #scrollCursorIntoView for iOS
Change 498910 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.Surface: Call #scrollCursorIntoView in some more cases
Root cause of this is an iOS Safari bug, not a problem in our code (Safari just scrolls the page to completely the wrong place when we restore the selection after closing the toolbar menu). My patches attempts to override this, and at a glance, they seem to work.
However, it would take us quite some effort to verify that this doesn't mess with the scrolling in other situations. I don't really want to spend too much time on this without talking about it. I'll abandon this for now.
Change 498650 abandoned by Bartosz Dziewoński:
ve.ui.Surface: Maybe fix #scrollCursorIntoView for iOS
Reason:
See task
Change 498910 abandoned by Bartosz Dziewoński:
ve.ui.Surface: Call #scrollCursorIntoView in some more cases
Reason:
See task
To verify that it's a Safari bug: place a breakpoint in ve.ce.Surface.prototype.showSelectionState on the line sel.addRange( newSel.getNativeRange( this.getElementDocument() ) ); and step over it, it just scrolls the selection straight out of view.
I didn't think of that, I guess we can… it causes a slightly ugly scrolling effect, but we can live with that I guess.
Change 499960 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.init.Target: Allow overriding surface (de)activation on mobile
Change 499961 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.MobileArticleTarget: Save/restore scroll position on surface (de)activation
Change 499960 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.init.Target: Allow overriding surface (de)activation on mobile
Change 500087 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (549f49bb5)
Change 500087 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (549f49bb5)
Change 499961 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.MobileArticleTarget: Save/restore scroll position on surface (de)activation