A partially blocked admin can delete a page that they aren't blocked from, but is not able to undelete it.
The admin is able to see the page Special:Undelete/<Title> but the widget for restoring the page does not appear.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix partially blocked admin undelete permissions | mediawiki/core | master | +4 -2 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Undeleting is complicated by the fact that, once a page is deleted, the block no longer has a restriction against it, because the page ID is no longer in the page table. That means that a user blocked from Foo could undelete the page Foo if it is deleted.
We could keep track of restrictions on deleted pages via the archive table, but IDs are not guaranteed to be stable over deletions and restorations of the same page.
What a blocked user with the 'undelete' right can access, before this task is fixed:
| Type of Block | Special:Undelete | Special:Undelete/Foo |
| Sitewide | Yes | No |
| Partial against Bar | Yes | Yes, but widgets for restoring are not loaded |
| Partial against Foo | Yes | Yes, but widgets for restoring are not loaded |
What a blocked user with the 'undelete' right will be able to access, if we load the widgets whenever the block does not apply to the page:
| Type of Block | Special:Undelete | Special:Undelete/Foo |
| Sitewide | Yes | No |
| Partial against Bar | Yes | Yes |
| Partial against Foo | Yes | Yes, because Foo is deleted - but they will be blocked again if Foo is restored with the same page ID |
I think we should still fix this, because users should be able to undelete pages they are not blocked from; we could address tracking restrictions of deleted pages separately if we think it's important.
Comment Actions
Right so basically a partially blocked user with the undelete right should be to restore any page. They'll just be unable to do any other actions on it once it is restored (if the id happens to be the same after restoration)
Comment Actions
This fails a bit lower in priority in me as we are overblocking which is the preferable failure case here, IMO. Not that we shouldn't fix it, just that it doesn't feel all that pressing.
Comment Actions
Change 500082 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@master] Fix partially blocked admin undelete permissions
Comment Actions
Change 500082 merged by jenkins-bot:
[mediawiki/core@master] Fix partially blocked admin undelete permissions
Comment Actions
After partially blocking my admin, successfully undeleted a page via web.
If blocked from Article or sitewide, attempting to undelete get:
"The action you have requested is limited to users in one of the groups: Administrators, Oversighters, Researchers, Check users."
Which is confusing as my user is an admin. Probably not a regression, though (could not verify this on test.wikipedia as I cannot block myself due to T219240).
Was also able to successfully restore a deleted file via the API, choosing to restore only one file from the file history.
I was blocked from doing so when I was sitewide blocked.
The change is so minor that I do not feel anymore testing is necessary.
Environment:
https://en.wikipedia.beta.wmflabs.org
MediaWiki 1.33.0-alpha (9dfa200) 08:05, 2 April 2019