Page MenuHomePhabricator
Create Task
Maniphest T219529

respect $exptime in RESTBagOStuff::incr()
Open, Needs TriagePublic
Actions

Description

from https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/includes/libs/objectcache/RESTBagOStuff.php#154

I don't see $exptime in the signature for BagOStuff::incr(), so I don't know how this should be handled. Also, this is not important for session storage, which I think would not use this method.

per @aaron

Event Timeline

EvanProdromou created this task.Mar 28 2019, 4:27 PM
EvanProdromou removed a parent task: T215533: Enable use of session storage service in MediaWiki.Jun 10 2019, 2:23 PM
EvanProdromou removed a project: Platform Engineering (Session Management Service (CDP2)).

We don't need this for using RESTBagOStuff with Kask for sessions, so I'm taking it out of the epic and removing the session tag.

CCicalese_WMF added a comment.Jun 10 2019, 2:26 PM

It does, however, need to be associated with some project on the Core Platform Team workboard.

Aklapper added a project: MediaWiki-libs-BagOStuff.Jun 10 2019, 2:45 PM

This task seems to be about MediaWiki-libs-BagOStuff hence adding code project tag.

• Mholloway unsubscribed.Jun 10 2019, 2:50 PM
Krinkle moved this task from General to libs/objectcache on the MediaWiki-libs-BagOStuff board.Jun 14 2019, 1:21 PM
WDoranWMF removed a project: Platform Team Legacy (Next).Jul 26 2019, 7:55 PM
BPirkle removed BPirkle as the assignee of this task.May 26 2021, 5:18 PM

Removing myself as assignee because I am not currently working on this, and am not scheduled to in the near future. I would not object to working on it on the future if plans and priorities allow, but I do not want to give a false impression of status or discourage anyone else from taking it over.

Eevans removed a project: User-Eevans.Jun 9 2021, 4:42 PM
Krinkle moved this task from libs/objectcache to General on the MediaWiki-libs-BagOStuff board.Jan 22 2022, 11:25 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptJan 22 2022, 11:25 PM
Krinkle removed a project: Performance-Team.Jan 24 2022, 7:39 PM
Krinkle edited projects, added MediaWiki-Platform-Team (Radar); removed User-Clarakosi.Mar 26 2024, 7:20 PM
Krinkle moved this task from General to Confirmed problem on the MediaWiki-libs-BagOStuff board.
Krinkle removed subscribers: • Clarakosi, • Fjalapeno.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits