Maniphest T219695

Flaky test BlockListPagerTest::testFormatValue
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

1) BlockListPagerTest::testFormatValue with data set #5 (…)
=== Logs generated by test case
[wfDebug] [debug] SpecialPage::getContext called and $mContext is null. Return RequestContext::getMain(); for sanity
[GlobalTitleFail] [info] RequestContext::getTitle called by BlockListPager->formatValue/ContextSource->msg/RequestContext->msg/Message->setContext/RequestContext->getTitle with no title set.
===
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'infinite<br />0 minutes left'
+'infinite<br />-1 minute left'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/specials/pagers/BlockListPagerTest.php:32

Causing some CI false negatives on Travis CI (https://travis-ci.org/wikimedia/mediawiki/jobs/513327423). Haven't seen it locally or in Jenkins (yet).

Looks like a race condition due to reliance on real-time.

Details

	Subject	Repo	Branch	Lines +/-
	Fix flaky test BlockListPagerTest::testFormatValue	mediawiki/core	master	+12 -13

Customize query in gerrit

Related Objects

Mentioned Here: rMW170c49d61cb8: Update Special:BlockList to present Partial Block details from the database
T197143: Update Special:BlockList with partial block info

Event Timeline

Krinkle created this task.Mar 30 2019, 3:19 AM

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptMar 30 2019, 3:19 AM

Git says it was introduced in 170c49d61c (ref T197143, Gerrit change).

You can use MWTimestamp::setFakeTime and must replace time() in BlockListPager with MWTimestamp::now()

dbarratt claimed this task.Apr 1 2019, 2:04 PM

dbarratt changed the subtype of this task from "Task" to "Bug Report".

dbarratt edited projects, added Anti-Harassment (Zayin - ז); removed Anti-Harassment.

dbarratt moved this task from Ready to In Progress on the Anti-Harassment (Zayin - ז) board.

Change 500462 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Fix flaky test BlockListPagerTest::testFormatValue

https://gerrit.wikimedia.org/r/500462

gerritbot added a project: Patch-For-Review.Apr 1 2019, 2:28 PM

dbarratt moved this task from In Progress to Review on the Anti-Harassment (Zayin - ז) board.Apr 1 2019, 2:29 PM

Krinkle moved this task from Untriaged to In progress on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.Apr 1 2019, 4:16 PM

dbarratt moved this task from Review to QA/Testing on the Anti-Harassment (Zayin - ז) board.Apr 1 2019, 5:07 PM

Change 500462 merged by jenkins-bot:
[mediawiki/core@master] Fix flaky test BlockListPagerTest::testFormatValue

https://gerrit.wikimedia.org/r/500462

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Apr 1 2019, 6:03 PM

Krinkle moved this task from In progress to Resolved on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.Apr 2 2019, 2:49 AM

No failures on https://travis-ci.org/wikimedia/mediawiki/builds for the last 7 days.

The time left till block expiration appears to show accurately on Special:BlockList.

Umherirrender closed this task as Resolved.Apr 6 2019, 7:40 PM

Umherirrender triaged this task as Medium priority.

• mmodell changed the subtype of this task from "Bug Report" to "Production Error".Aug 28 2019, 11:07 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:37 PM

Flaky test BlockListPagerTest::testFormatValueClosed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Related Objects

Event Timeline

Flaky test BlockListPagerTest::testFormatValue
Closed, ResolvedPublicPRODUCTION ERROR
Actions