Page MenuHomePhabricator
Create Task
Maniphest T221514

PageTriage: Marking a page as under review shouldn't mark it as reviewed
Closed, ResolvedPublicSpike
Actions

Description

Steps to reproduce:

  1. Go to an article
  2. Add the tag "under review"

Expected behaviour:
The page is not yet reviewed

Actual result:
The page is marked as reviewed

Selected the option caused both https://en.wikipedia.org/w/index.php?title=Special:Log&logid=98594033 and https://en.wikipedia.org/w/index.php?title=Special:Log&logid=98594032 (marking it as under review and reviewing it)

Ideally, adding any tag wouldn't automatically review the page, but especially not the tag that explains the page is currently being reviewed (and thus hasn't yet been reviewed fully)

Details

SubjectRepoBranchLines +/-
Maintenance tagging should not mark article as reviewed by defaultmediawiki/extensions/PageTriagemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Apr 21 2019, 8:06 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 21 2019, 8:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 added a comment.Jun 1 2019, 6:16 AM

Potential duplicate of T148353 - though this deals with one specific tag, that task is generalized to any tag.

DannyS712 moved this task from Unsorted to Page Curation on the User-DannyS712 board.Jun 30 2019, 7:23 PM
JTannerWMF added a project: Community-Tech.Jul 23 2019, 8:50 PM
JTannerWMF subscribed.

Tagging the Community-Tech team because they are working on Page Curation.

JTannerWMF moved this task from Inbox to External on the Growth-Team board.Jul 23 2019, 9:03 PM
MBinder_WMF changed the subtype of this task from "Task" to "Spike".Jul 23 2019, 11:46 PM
ifried removed a project: Community-Tech.Aug 8 2019, 10:56 PM
ifried subscribed.

• I'm removing the Community Tech label from this ticket, as this work is not a part of the community wishlist.

DannyS712 mentioned this in T207438: Page curation toolbar: allow a reviewer to mark a page as 'under review' and warn others at Special:NewPagesFeed.Aug 17 2019, 12:26 AM
DannyS712 mentioned this in T207442: Send Message to creator without needing to 'unreview'/'re-review' the article.
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM
MPGuy2824 subscribed.Sep 14 2022, 9:49 AM

Looking at the links in the description, the article wasn't marked as patrolled, but as reviewed. I guess this is related to T316978: Maintenance tagging should not mark article as reviewed by default.

gerritbot added a comment.Sep 14 2022, 10:11 AM

Change 832236 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] Maintenance tagging should not mark article as reviewed by default

https://gerrit.wikimedia.org/r/832236

gerritbot added a project: Patch-For-Review.Sep 14 2022, 10:11 AM
Novem_Linguae moved this task from Backlog to Code Review on the PageTriage board.Sep 14 2022, 10:13 AM
Novem_Linguae renamed this task from PageTriage: Marking a page as under review shouldn't mark it as patrolled to PageTriage: Marking a page as under review shouldn't mark it as reviewed.Sep 14 2022, 10:15 AM
Novem_Linguae updated the task description. (Show Details)
gerritbot added a comment.Sep 22 2022, 2:07 AM

Change 832236 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Maintenance tagging should not mark article as reviewed by default

https://gerrit.wikimedia.org/r/832236

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2022, 2:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 22 2022, 3:00 AM
MPGuy2824 moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.Sep 22 2022, 3:20 AM
Novem_Linguae closed this task as Resolved.Sep 22 2022, 3:49 AM
Novem_Linguae claimed this task.
Novem_Linguae moved this task from Waiting for enwiki deploy to Done on the PageTriage board.
Novem_Linguae moved this task from Done to Waiting for enwiki deploy on the PageTriage board.Sep 22 2022, 3:59 AM
MPGuy2824 moved this task from Waiting for enwiki deploy to Done on the PageTriage board.Sep 30 2022, 4:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL