Page MenuHomePhabricator

[Regression pre-wmf.2] After inserting a link, annotation cartouche and context menu is not active
Closed, ResolvedPublic

Description

After inserting a link, annotation cartouche and context menu is not active.

Expected (production):

image.png (980×1 px, 151 KB)

Actual (Beta):

image.png (980×1 px, 147 KB)

Event Timeline

Heh. Amusingly (?) I remember explicitly testing that post-link stuff, and completely missing that the context behavior had changed because I was entirely focused on the select-inside aspect..

I don't think that was a rebase error, but I was specifically testing that case, so odd that I broke it. Will have a look..

Ok, the code I put in ve.ce.Surface.prototype.activate covered the case where you edit a link (which is what I tested), but when you insert a link previousActiveAnnotations is empty so nothing happens.

Change 506671 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Update activeAnnotations when applying new annotation

https://gerrit.wikimedia.org/r/506671

Change 506671 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Update activeAnnotations when applying new annotation

https://gerrit.wikimedia.org/r/506671

Change 507091 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (36e90285e)

https://gerrit.wikimedia.org/r/507091

Change 507091 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (36e90285e)

https://gerrit.wikimedia.org/r/507091