After inserting a link, annotation cartouche and context menu is not active.
Expected (production):
Actual (Beta):
matmarex | |
Apr 23 2019, 9:22 PM |
F28746585: image.png | |
Apr 23 2019, 9:22 PM |
F28746588: image.png | |
Apr 23 2019, 9:22 PM |
After inserting a link, annotation cartouche and context menu is not active.
Expected (production):
Actual (Beta):
Bisect blames rEVED24cb70bae03f: Update VE core submodule to master (6afc66096) → rGVED4e32f62c373f: Re-use previousSelection when re-activating
That commit removed a bunch of code added in rGVED5b233d7db93d: Create more methods for finding/selecting current annotations. That looks like it may have been a rebase mistake or something?
Heh. Amusingly (?) I remember explicitly testing that post-link stuff, and completely missing that the context behavior had changed because I was entirely focused on the select-inside aspect..
I don't think that was a rebase error, but I was specifically testing that case, so odd that I broke it. Will have a look..
Ok, the code I put in ve.ce.Surface.prototype.activate covered the case where you edit a link (which is what I tested), but when you insert a link previousActiveAnnotations is empty so nothing happens.
Change 506671 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Update activeAnnotations when applying new annotation
Change 506671 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Update activeAnnotations when applying new annotation
Change 507091 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (36e90285e)
Change 507091 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (36e90285e)