Page MenuHomePhabricator
Create Task
Maniphest T222697

Implement generic overlay capability
Closed, ResolvedPublic
Actions

Description

  • research 3rd party solutions
  • for this story behaves as a modal, decision needs to be taken through buttons, can not be "clicked away" through e.g. the overlay background ("gray box")

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+1 -1termbox: use latest
wikibase/termboxmaster+15 -0Modal: add storybook
wikibase/termboxmaster+53 -0Introduce generic modal component
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pablo-WMDE created this task.May 7 2019, 10:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2019, 10:01 AM
• Matthias_Geisler_WMDE added a subscriber: • Matthias_Geisler_WMDE.May 8 2019, 5:30 AM

Maybe a good candidate for 3rd party?: https://www.npmjs.com/package/vue-js-modal

Jakob_WMDE claimed this task.May 8 2019, 11:31 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-15 board.
gerritbot added a comment.May 10 2019, 12:27 PM

Change 509372 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Introduce generic modal component

https://gerrit.wikimedia.org/r/509372

gerritbot added a project: Patch-For-Review.May 10 2019, 12:27 PM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-15 board.May 10 2019, 1:47 PM
gerritbot added a comment.May 14 2019, 2:23 PM

Change 510172 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] Modal: add storybook

https://gerrit.wikimedia.org/r/510172

gerritbot added a comment.May 15 2019, 11:26 AM

Change 509372 merged by jenkins-bot:
[wikibase/termbox@master] Introduce generic modal component

https://gerrit.wikimedia.org/r/509372

gerritbot added a comment.May 15 2019, 11:28 AM

Change 510172 merged by jenkins-bot:
[wikibase/termbox@master] Modal: add storybook

https://gerrit.wikimedia.org/r/510172

Jakob_WMDE moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-15 board.May 15 2019, 12:18 PM
gerritbot added a comment.May 17 2019, 10:21 AM

Change 510835 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] termbox: use latest

https://gerrit.wikimedia.org/r/510835

gerritbot added a comment.May 17 2019, 5:30 PM

Change 510835 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] termbox: use latest

https://gerrit.wikimedia.org/r/510835

Ladsgroup removed a project: Patch-For-Review.May 21 2019, 10:09 PM
Jakob_WMDE closed this task as Resolved.May 22 2019, 9:25 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL