Some dot-separators in recent changes and watchlist are missing surrounding whitespace
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	matej_suchanek
	May 9 2019, 3:46 PM

Description

Seen quite some time ago. But still present.

Steps to Reproduce:

Watch some frequently edited page.
Have "Group results by page" in Watchlist (or RC) enabled.
Uncollapse some block of changes.

Actual Results:

As the screenshot shows, some of those separators are missing surrounding whitespace (red underline), whereas others do have it (blue underline).

Example from my watchlist on wikidata.org.

Developer notes

Sample HTML shows missing spaces

`
<td class="mw-changeslist-line-inner"> <span class="mw-title"><a href="/w/index.php?title=Talk:Arabic_language" class="mw-changeslist-title" title="Talk:Arabic language">Talk:Arabic language</a></span>&lrm;&lrm; <span class="mw-changeslist-links"><span>8 changes</span> <span><a href="/w/index.php?title=Talk:Arabic_language&amp;curid=1069&amp;action=history" class="mw-changeslist-history" title="Talk:Arabic language">history</a></span></span><span class="mw-changeslist-separator"></span><strong dir="ltr" class="mw-plusminus-pos mw-diff-bytes" title="738 bytes after change">+738</strong>&lrm; <span class="mw-changeslist-separator"></span><span class="changedby">[<a href="/w/index.php?title=User:Toby&amp;action=edit&amp;redlink=1" class="new mw-userlink" title="User:Toby (page does not exist)"><bdi>Toby</bdi></a>&lrm; (8×)]</span></td>

`

Inserting a space character before mw-changeslist-separator opening tag and after it's closing tag should take care of this

Details

	Subject	Repo	Branch	Lines +/-
	Fix recent changes and watchlist separator whitespace	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T219348 RecentChanges should be fully skinnable - use pseudo elements for separating elements
		Resolved	BUG REPORT	Ed	T222903 Some dot-separators in recent changes and watchlist are missing surrounding whitespace

Event Timeline

matej_suchanek created this task.May 9 2019, 3:46 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 9 2019, 3:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

matej_suchanek updated the task description. (Show Details)May 9 2019, 3:46 PM

Aklapper removed a project: UI-Standardization.May 9 2019, 3:50 PM

Where exactly to enable "Group changes by page"?

Excuse my typo, fixed in description:

Jdlrobson edited parent tasks, added: T219348: RecentChanges should be fully skinnable - use pseudo elements for separating elements; removed: T205581: History, Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements.Jul 3 2019, 5:40 PM

Tentatively moving to Q2.

Jdlrobson updated the task description. (Show Details)Jul 18 2019, 9:37 PM

Jdlrobson added a project: good first task.

Ed claimed this task.Jul 30 2019, 5:53 PM

Change 526501 had a related patch set uploaded (by Ed; owner: Ed):
[mediawiki/core@master] Fix recent changes and watchlist separator whitespace

https://gerrit.wikimedia.org/r/526501

gerritbot added a project: Patch-For-Review.Jul 30 2019, 5:56 PM

Change 526501 merged by jenkins-bot:
[mediawiki/core@master] Fix recent changes and watchlist separator whitespace

https://gerrit.wikimedia.org/r/526501

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Jul 30 2019, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 30 2019, 10:10 PM

@matej_suchanek, would you be able to confirm this is fixed on https://en.wikipedia.beta.wmflabs.org/ ?

Yes, but I notice another excessive whitespace:

I see this too. Guess this is not completely solved just yet!

<span class="mw-changeslist-links"><span>2 changes</span> <span>

^ space needs dropping there

<span class="mw-usertoollinks mw-changeslist-links"><span><a href="/wiki/User_talk:Selenium_user" class="mw-usertoollinks-talk" title="User talk:Selenium user">talk</a></span> <span><a href="/wiki/Special:Contributions/Selenium_user" class="mw-usertoollinks-contribs" title="Special:Contributions/Selenium user">contribs</a></span> <span><a href="/wiki/Special:Block/Selenium_user" class="mw-usertoollinks-block" title="Special:Block/Selenium user">block</a></span></span>

^ space needs dropping after contriibs</a>

Jdlrobson mentioned this in T219348: RecentChanges should be fully skinnable - use pseudo elements for separating elements.Sep 23 2019, 6:39 PM

Jdlrobson added a project: Advanced Mobile Contributions.Sep 23 2019, 6:41 PM

The remaining issues were caused by a weird override for https://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Pipe-separator:  | . I just deleted it and they're resolved.

I'm sure I saw this on some other Wikimedia wikis. We should probably look around for such overrides and have them deleted...

There was a similar problem at least on production English Wikipedia, but it was resolved there by deleting the override a couple months ago (April 2019: https://en.wikipedia.org/wiki/MediaWiki:Pipe-separator). I remember that there was some task discussing this, but I can't find it now.

matej_suchanek mentioned this in T234006: Extraneous space on commons' listusers.Feb 27 2020, 10:38 AM

I remember that there was some task discussing this, but I can't find it now.

T210851: Spacing between diff and pipe separator is double what it should be in Special:Contributions?

	F29930230: obrazek.png
	Aug 1 2019, 7:02 AM

	F29277356: obrazek.png
	May 30 2019, 11:25 AM

Some dot-separators in recent changes and watchlist are missing surrounding whitespaceClosed, ResolvedPublicBUG REPORTActions