Page MenuHomePhabricator

Remove deprecated using schema.* syntax from MultimediaViewer
Closed, ResolvedPublic


Code search tells me there are uses of something like `using( 'schema.*' ) in:

  • resources/mmv.bootstrap/mmv.logging.Logger.js#85
  • tests/qunit/mmv/logging/mmv.logging.DurationLogger.test.js#189
  • tests/qunit/mmv/logging/mmv.logging.DurationLogger.test.js#200
  • tests/qunit/mmv/logging/mmv.logging.DurationLogger.test.js#211

I'm going to change this to just remove references to schema.* modules. There's also a method that checks whether schemas contain the "country" property. This code is now broken since schema modules are just shells. So I've just replaced it with a static check.

Event Timeline

UPDATE: if you saw the message below you can just disregard it, I'll do it a simpler way and send a patch soon. We're fine using logEvent and you can move to mw.track later if you like. Apologies for the noise.

@Cparle, @matthiasmullie, @MarkTraceur, @egardner, or anyone on Multimedia, I started working on migrating your instrumentation from mw.eventLog.logEvent to mw.track but it's pretty embedded in there with tests and all that. Can one of you get to it soon? If not, I can finish hacking on it and send the change. Let me know either way.

Change 510283 had a related patch set uploaded (by Milimetric; owner: Milimetric):
[mediawiki/extensions/MultimediaViewer@master] Remove mentions of schema.* ResourceLoader modules

Change 510283 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Remove mentions of schema.* ResourceLoader modules

mforns triaged this task as High priority.May 16 2019, 5:08 PM
mforns moved this task from Incoming to Operational Excellence on the Analytics board.