Remove deprecated using schema.* syntax from MultimediaViewer
Closed, ResolvedPublic
Actions

Description

Code search tells me there are uses of something like `using( 'schema.*' ) in:

resources/mmv.bootstrap/mmv.logging.Logger.js#85
tests/qunit/mmv/logging/mmv.logging.DurationLogger.test.js#189
tests/qunit/mmv/logging/mmv.logging.DurationLogger.test.js#200
tests/qunit/mmv/logging/mmv.logging.DurationLogger.test.js#211

I'm going to change this to just remove references to schema.* modules. There's also a method that checks whether schemas contain the "country" property. This code is now broken since schema modules are just shells. So I've just replaced it with a static check.

Details

	Subject	Repo	Branch	Lines +/-
	Remove mentions of schema.* ResourceLoader modules	mediawiki/extensions/MultimediaViewer	master	+14 -7

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Krinkle	T219342 Pageview performance timeline analysis (March 2019)
Resolved	Milimetric	T221281 Remove deprecated EventLogging schema modules
Resolved	Milimetric	T223284 Remove deprecated using schema.* syntax from MultimediaViewer

Event Timeline

Milimetric created this task.May 14 2019, 3:21 PM

Milimetric updated the task description. (Show Details)May 14 2019, 3:24 PM

UPDATE: if you saw the message below you can just disregard it, I'll do it a simpler way and send a patch soon. We're fine using logEvent and you can move to mw.track later if you like. Apologies for the noise.

@Cparle, @matthiasmullie, @MarkTraceur, @egardner, or anyone on Multimedia, I started working on migrating your instrumentation from mw.eventLog.logEvent to mw.track but it's pretty embedded in there with tests and all that. Can one of you get to it soon? If not, I can finish hacking on it and send the change. Let me know either way.

Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.May 15 2019, 12:01 AM

Change 510283 had a related patch set uploaded (by Milimetric; owner: Milimetric):
[mediawiki/extensions/MultimediaViewer@master] Remove mentions of schema.* ResourceLoader modules

https://gerrit.wikimedia.org/r/510283

gerritbot added a project: Patch-For-Review.May 15 2019, 1:00 AM

Milimetric updated the task description. (Show Details)May 15 2019, 1:02 AM

Milimetric moved this task from Next Up to In Code Review on the Analytics-Kanban board.May 15 2019, 1:23 AM

Change 510283 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Remove mentions of schema.* ResourceLoader modules

https://gerrit.wikimedia.org/r/510283

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 16 2019, 7:00 AM

Milimetric moved this task from In Code Review to Done on the Analytics-Kanban board.May 16 2019, 2:21 PM

mforns triaged this task as High priority.May 16 2019, 5:08 PM

mforns moved this task from Incoming to Operational Excellence on the Analytics board.

Krinkle removed a project: Performance-Team (Radar).May 20 2019, 11:07 PM

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 3:12 PM