Page MenuHomePhabricator

commonswiki: id3handler ErrorException from line 16 of WebMHandler.php: PHP Notice: Undefined index: comments
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

Request URL: https://commons.wikimedia.org/wiki/Special:UploadWizard
Request ID: XN1gPQpAEMQAAGSN2FcAAAAK

message
ErrorException from line 16 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/TimedMediaHandler/includes/handlers/WebMHandler/WebMHandler.php: PHP Notice: Undefined index: comments
trace
#0 /srv/mediawiki/php-1.34.0-wmf.5/extensions/TimedMediaHandler/includes/handlers/WebMHandler/WebMHandler.php(16): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.34.0-wmf.5/extensions/TimedMediaHandler/includes/handlers/ID3Handler/ID3Handler.php(51): WebMHandler->getID3(string)
#2 /srv/mediawiki/php-1.34.0-wmf.5/includes/utils/MWFileProps.php(84): ID3Handler->getMetadata(FSFile, string)
#3 /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php(506): MWFileProps->getPropsFromPath(string, string)
#4 /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php(441): UploadBase->verifyPartialFile()
#5 /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php(344): UploadBase->verifyFile()
#6 /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadFromFile.php(95): UploadBase->verifyUpload()
#7 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiUpload.php(547): UploadFromFile->verifyUpload()
#8 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiUpload.php(78): ApiUpload->verifyUpload()
#9 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiMain.php(1593): ApiUpload->execute()
#10 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiMain.php(531): ApiMain->executeAction()
#11 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#12 /srv/mediawiki/php-1.34.0-wmf.5/api.php(87): ApiMain->execute()
#13 /srv/mediawiki/w/api.php(3): include(string)
#14 {main}

Impact

Notes

Event Timeline

Change 510828 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TimedMediaHandler@master] WebMHandler: Check for Matroska ID3 comment field existing before reading

https://gerrit.wikimedia.org/r/510828

I believe that this is due to a corrupt user file being uploaded, and so shouldn't be considered a train blocker; the code has been this way since 2017 in adc5f640c.

Reedy renamed this task from commonswiki: id3handler ErrorException from line 16 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/TimedMediaHandler/includes/handlers/WebMHandler/WebMHandler.php: PHP Notice: Undefined index: comments to commonswiki: id3handler ErrorException from line 16 of WebMHandler.php: PHP Notice: Undefined index: comments.May 17 2019, 9:55 PM

Change 510828 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] WebMHandler: Check for Matroska ID3 comment field existing before reading

https://gerrit.wikimedia.org/r/510828

Jdforrester-WMF claimed this task.
Jdforrester-WMF removed a project: Patch-For-Review.

Provisionally claiming that this will be fixed with the next train.

Change 511045 had a related patch set uploaded (by Krinkle; owner: Jforrester):
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.5] WebMHandler: Check for Matroska ID3 comment field existing before reading

https://gerrit.wikimedia.org/r/511045

Change 511045 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.5] WebMHandler: Check for Matroska ID3 comment field existing before reading

https://gerrit.wikimedia.org/r/511045

Mentioned in SAL (#wikimedia-operations) [2019-05-18T15:57:31Z] <krinkle@deploy1001> Synchronized php-1.34.0-wmf.5/extensions/TimedMediaHandler/includes/handlers/WebMHandler/WebMHandler.php: T223445 / rETMHa9df59c59d7a (duration: 00m 51s)

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM