commonswiki: id3handler ErrorException from line 16 of WebMHandler.php: PHP Notice: Undefined index: comments
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	hashar
	May 16 2019, 1:11 PM

Description

Error

Request URL: https://commons.wikimedia.org/wiki/Special:UploadWizard
Request ID: XN1gPQpAEMQAAGSN2FcAAAAK

message

ErrorException from line 16 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/TimedMediaHandler/includes/handlers/WebMHandler/WebMHandler.php: PHP Notice: Undefined index: comments

trace

#0 /srv/mediawiki/php-1.34.0-wmf.5/extensions/TimedMediaHandler/includes/handlers/WebMHandler/WebMHandler.php(16): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.34.0-wmf.5/extensions/TimedMediaHandler/includes/handlers/ID3Handler/ID3Handler.php(51): WebMHandler->getID3(string)
#2 /srv/mediawiki/php-1.34.0-wmf.5/includes/utils/MWFileProps.php(84): ID3Handler->getMetadata(FSFile, string)
#3 /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php(506): MWFileProps->getPropsFromPath(string, string)
#4 /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php(441): UploadBase->verifyPartialFile()
#5 /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php(344): UploadBase->verifyFile()
#6 /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadFromFile.php(95): UploadBase->verifyUpload()
#7 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiUpload.php(547): UploadFromFile->verifyUpload()
#8 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiUpload.php(78): ApiUpload->verifyUpload()
#9 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiMain.php(1593): ApiUpload->execute()
#10 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiMain.php(531): ApiMain->executeAction()
#11 /srv/mediawiki/php-1.34.0-wmf.5/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#12 /srv/mediawiki/php-1.34.0-wmf.5/api.php(87): ApiMain->execute()
#13 /srv/mediawiki/w/api.php(3): include(string)
#14 {main}

Impact

Notes

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	WebMHandler: Check for Matroska ID3 comment field existing before reading	mediawiki/extensions/TimedMediaHandler	wmf/1.34.0-wmf.5	+8 -4
	WebMHandler: Check for Matroska ID3 comment field existing before reading	mediawiki/extensions/TimedMediaHandler	master	+8 -4

Customize query in gerrit

Related Objects

Mentioned In: T220730: 1.34.0-wmf.5 deployment blockers
Mentioned Here: rETMHa9df59c59d7a: WebMHandler: Check for Matroska ID3 comment field existing before reading
rETMHadc5f640c735: Retain some WebM metadata for processing purposes

Event Timeline

hashar created this task.May 16 2019, 1:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 16 2019, 1:11 PM

hashar moved this task from Untriaged to Oct2019/1.35.wmf.1+ on the Wikimedia-production-error board.May 16 2019, 1:13 PM

hashar moved this task from Oct2019/1.35.wmf.1+ to May 2019 / 1.34.wmf.5+ on the Wikimedia-production-error board.May 16 2019, 1:16 PM

hashar added a parent task: T220730: 1.34.0-wmf.5 deployment blockers.May 16 2019, 1:28 PM

Change 510828 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TimedMediaHandler@master] WebMHandler: Check for Matroska ID3 comment field existing before reading

https://gerrit.wikimedia.org/r/510828

gerritbot added a project: Patch-For-Review.May 17 2019, 9:29 AM

I believe that this is due to a corrupt user file being uploaded, and so shouldn't be considered a train blocker; the code has been this way since 2017 in adc5f640c.

Jdforrester-WMF moved this task from To sort to Doing on the TimedMediaHandler board.May 17 2019, 10:37 AM

indeed, thank you :)

hashar mentioned this in T220730: 1.34.0-wmf.5 deployment blockers.May 17 2019, 3:29 PM

Reedy renamed this task from commonswiki: id3handler ErrorException from line 16 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/TimedMediaHandler/includes/handlers/WebMHandler/WebMHandler.php: PHP Notice: Undefined index: comments to commonswiki: id3handler ErrorException from line 16 of WebMHandler.php: PHP Notice: Undefined index: comments.May 17 2019, 9:55 PM

Change 510828 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] WebMHandler: Check for Matroska ID3 comment field existing before reading

https://gerrit.wikimedia.org/r/510828

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 17 2019, 11:01 PM

Provisionally claiming that this will be fixed with the next train.

Change 511045 had a related patch set uploaded (by Krinkle; owner: Jforrester):
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.5] WebMHandler: Check for Matroska ID3 comment field existing before reading

https://gerrit.wikimedia.org/r/511045

gerritbot added a project: Patch-For-Review.May 18 2019, 3:15 PM

Change 511045 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.5] WebMHandler: Check for Matroska ID3 comment field existing before reading

https://gerrit.wikimedia.org/r/511045

Mentioned in SAL (#wikimedia-operations) [2019-05-18T15:57:31Z] <krinkle@deploy1001> Synchronized php-1.34.0-wmf.5/extensions/TimedMediaHandler/includes/handlers/WebMHandler/WebMHandler.php: T223445 / rETMHa9df59c59d7a (duration: 00m 51s)

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.5; 2019-05-14); removed MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 18 2019, 4:01 PM

Jdforrester-WMF edited projects, added Release-Engineering-Team (Kanban); removed Patch-For-Review.May 29 2019, 4:48 PM

Jdforrester-WMF moved this task from Backlog to Done (within RelEng) on the Release-Engineering-Team (Kanban) board.May 29 2019, 4:50 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM

commonswiki: id3handler ErrorException from line 16 of WebMHandler.php: PHP Notice: Undefined index: commentsClosed, ResolvedPublicPRODUCTION ERRORActions