Use user preference value to avoid "You are not logged in" overlay
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pablo-WMDE
	May 21 2019, 11:31 AM

Description

In Termbox.vue read the respective user setting from the store, and make it part of the condition of whether AnonEditWarning is shown or not.

Details

	Subject	Repo	Branch	Lines +/-
	Do not show AnonEditWarning if HIDE_ANON_EDIT_WARNING is set	wikibase/termbox	master	+32 -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T219158 'IP visibility' and 'Terms of use' information on termbox editing
Resolved	• Lea_WMDE	T221833 Add the "Remember my choice" checkbox to the "You are not logged in" popup on mobile termbox editing, and remember user's choice
Resolved	Jakob_WMDE	T223987 Use user preference value to avoid "You are not logged in" overlay

Event Timeline

• Pablo-WMDE created this task.May 21 2019, 11:31 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2019, 11:31 AM

• Pablo-WMDE renamed this task from Create user preference value to avoid "You are not logged in" overlay to Use user preference value to avoid "You are not logged in" overlay.May 21 2019, 11:34 AM

Jakob_WMDE updated the task description. (Show Details)May 21 2019, 1:33 PM

WMDE-leszek added a project: Wikidata-Termbox-Iteration-17.Jun 3 2019, 10:39 AM

Jakob_WMDE claimed this task.Jun 3 2019, 1:15 PM

Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-17 board.

Change 514036 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Do not show AnonEditWarning if HIDE_ANON_EDIT_WARNING is set

https://gerrit.wikimedia.org/r/514036

gerritbot added a project: Patch-For-Review.Jun 3 2019, 3:36 PM

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-17 board.Jun 3 2019, 3:54 PM

Change 514036 merged by jenkins-bot:
[wikibase/termbox@master] Do not show AnonEditWarning if HIDE_ANON_EDIT_WARNING is set

https://gerrit.wikimedia.org/r/514036

• Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-17 board.Jun 5 2019, 3:11 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2019, 4:10 PM

Jakob_WMDE closed this task as Resolved.Jul 1 2019, 9:14 AM