Page MenuHomePhabricator
Create Task
Maniphest T221833

Add the "Remember my choice" checkbox to the "You are not logged in" popup on mobile termbox editing, and remember user's choice
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Given I am not logged in
And I have checked the "Remember my choice" option in the popup
When I click edit
Then I am not presented with the "You are not logged in" popup

Mock:

Bildschirmfoto 2019-05-09 um 16.29.14.png (560×622 px, 46 KB)

Acceptance Criteria:

  • There is a "remember my choice" checkbox as shown in the mock
  • The checkbox is by default checked
  • When the checkbox is unchecked, once the user clicks on either of the three buttons, it is saved that the user will not see the message ever again, but would immediately proceed to anonymous editing next time they click on the edit button anonymously

Dev note:
The choice should be persisted on user's device as a "cookie"

Details

SubjectRepoBranchLines +/-
termbox: update pinmediawiki/extensions/Wikibasemaster+1 -1
AnonEditWarning: checkbox should be checked by defaultwikibase/termboxmaster+9 -2
Make CookieUserPreferenceRepository type-awarewikibase/termboxmaster+160 -63
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek created this task.Apr 25 2019, 8:59 AM
WMDE-leszek mentioned this in T219158: 'IP visibility' and 'Terms of use' information on termbox editing.
WMDE-leszek set the point value for this task to 5.
WMDE-leszek moved this task from Backlog to MVP things: Ready for pickup on the Wikidata-Termbox board.
WMDE-leszek renamed this task from Remember the choice in the "You are not logged in" popup on mobile termbox editing to Add the "Remember my choice" checkbox to the "You are not logged in" popup on mobile termbox editing, and remember user's choice.Apr 25 2019, 9:20 AM
• Hanna_Petruschat_WMDE added a comment.Apr 25 2019, 4:49 PM

Follow up question: Does this action need to be accompanied by a cookie pop up? Do we actually have stuff like that for Wikidata at all?

WMDE-leszek added a comment.Apr 26 2019, 8:14 AM
In T221833#5138098, @Hanna_Petruschat_WMDE wrote:

Follow up question: Does this action need to be accompanied by a cookie pop up? Do we actually have stuff like that for Wikidata at all?

I might be not answering the question you asked, but 1) Currently the Log in/Sign up bubble on desktop wikidata does not have the "remember my choice" option, and it is also generally different from the proposed one as it does allow to ignore the popup (i.e. to make an edit without making the decision in the popup), 2) if we do want to remember the choice of the editor, I believe it does have to be stored in some "cookie" (I write cookie in quotes, as it could also be local storage, or whatever browser use these days to store the user specific stuff)

Lydia_Pintscher added a comment.Apr 26 2019, 8:29 AM

Desktop used mediawiki's built-in function to store a preference. If the user is logged in then it stores this in an invisible preference and if not then in a cookie. We don't want to show the message repeatedly to logged in users just because they are using another computer.

Lydia_Pintscher added a comment.Apr 26 2019, 8:30 AM

Ah sorry. Ignore my comment. I thought we were talking about the CC 0 notification.

• Pablo-WMDE added a comment.Apr 26 2019, 8:57 AM

At the risk of adding confusion but I believe @Hanna_Petruschat_WMDE is refering to a GDPR cookie prompt [0] - an interesting product topic indeed but certainly (and pretty please) not at the heart of the termbox domain.
Queue product people: @Lydia_Pintscher @Lea_WMDE

[0] https://www.cookiebot.com/en/gdpr-cookies/

• Hanna_Petruschat_WMDE added a comment.Apr 29 2019, 8:18 AM

Thanks @Pablo-WMDE. This is exactly what I was going for.

@Lydia_Pintscher Even though this is not the exact ticket, it's good to read your comment, as we plan to follow exactly your described behaviour for the CC0 license in T221836

Lea_WMDE mentioned this in T221831: Add "You are not logged in" overlay popup on termbox editing.May 6 2019, 11:04 AM
Lea_WMDE triaged this task as Medium priority.May 6 2019, 11:10 AM
Lea_WMDE updated the task description. (Show Details)
Lea_WMDE updated the task description. (Show Details)May 9 2019, 2:33 PM
WMDE-leszek edited projects, added Wikidata-Termbox-Iteration-16; removed Wikidata-Termbox.May 20 2019, 10:42 AM
WMDE-leszek added a project: Wikidata-Termbox-Iteration-17.Jun 3 2019, 10:39 AM
Jakob_WMDE closed subtask T223982: Create custom checkbox component as Resolved.Jun 5 2019, 11:02 AM
gerritbot added a comment.Jun 5 2019, 2:18 PM

Change 514300 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Jakob):
[wikibase/termbox@master] Make CookieUserPreferenceRepository type-aware

https://gerrit.wikimedia.org/r/514300

gerritbot added a project: Patch-For-Review.Jun 5 2019, 2:18 PM
gerritbot added a comment.Jun 5 2019, 2:33 PM

Change 514300 merged by jenkins-bot:
[wikibase/termbox@master] Make CookieUserPreferenceRepository type-aware

https://gerrit.wikimedia.org/r/514300

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2019, 3:11 PM
gerritbot added a comment.Jun 5 2019, 3:53 PM

Change 514512 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] AnonEditWarning: checkbox should be checked by default

https://gerrit.wikimedia.org/r/514512

gerritbot added a project: Patch-For-Review.Jun 5 2019, 3:53 PM
gerritbot added a comment.Jun 5 2019, 4:14 PM

Change 514512 merged by jenkins-bot:
[wikibase/termbox@master] AnonEditWarning: checkbox should be checked by default

https://gerrit.wikimedia.org/r/514512

gerritbot added a comment.Jun 5 2019, 4:16 PM

Change 514524 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] termbox: update pin

https://gerrit.wikimedia.org/r/514524

gerritbot added a comment.Jun 5 2019, 5:18 PM

Change 514524 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] termbox: update pin

https://gerrit.wikimedia.org/r/514524

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 5 2019, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 5 2019, 6:10 PM
• Pablo-WMDE added a comment.Jun 6 2019, 8:26 AM

We are still working on some browser tests, but this is already showing on beta.
/cc @Lea_WMDE @Hanna_Petruschat_WMDE

Jakob_WMDE moved this task from To Do to Test (Product Review) on the Wikidata-Termbox-Iteration-17 board.Jun 6 2019, 8:28 AM
Lea_WMDE closed this task as Resolved.Jun 12 2019, 2:48 PM
Lea_WMDE claimed this task.
Lea_WMDE moved this task from Test (Product Review) to Done on the Wikidata-Termbox-Iteration-17 board.
Jakob_WMDE closed subtask T224976: Browser test persistence as Resolved.Jul 1 2019, 9:14 AM
Jakob_WMDE closed subtask T224540: Polish checkbox as Resolved.
Jakob_WMDE closed subtask T223987: Use user preference value to avoid "You are not logged in" overlay as Resolved.
Jakob_WMDE closed subtask T223985: Use checkbox in AnonEditWarning as Resolved.
Jakob_WMDE closed subtask T223986: Create user preference repository as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL