Page MenuHomePhabricator
Create Task
Maniphest T224545

UnexpectedValueException when looking at a Special:MobileDiff for an EntitySchema Revision
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request URL: https://www.wikidata.org/wiki/Special:MobileDiff/951170414
Request ID: XO4GxApAIC8AAEaLNhEAAACM

message
[XO4GxApAIC8AAEaLNhEAAACM] /wiki/Special:MobileDiff/951170414   UnexpectedValueException from line 52 of /srv/mediawiki/php-1.34.0-wmf.6/extensions/EntitySchema/src/MediaWiki/Content/EntitySchemaSlotDiffRenderer.php: Expected a TextSlotDiffRenderer
trace
#0 /srv/mediawiki/php-1.34.0-wmf.6/extensions/EntitySchema/src/MediaWiki/Content/EntitySchemaContentHandler.php(43): EntitySchema\MediaWiki\Content\EntitySchemaSlotDiffRenderer->__construct(RequestContext)
#1 /srv/mediawiki/php-1.34.0-wmf.6/includes/content/ContentHandler.php(618): EntitySchema\MediaWiki\Content\EntitySchemaContentHandler->getSlotDiffRendererInternal(RequestContext)
#2 /srv/mediawiki/php-1.34.0-wmf.6/includes/diff/DifferenceEngine.php(255): ContentHandler->getSlotDiffRenderer(RequestContext)
#3 [internal function]: Closure$DifferenceEngine::getSlotDiffRenderers(array)
#4 /srv/mediawiki/php-1.34.0-wmf.6/includes/diff/DifferenceEngine.php(256): array_map(Closure$DifferenceEngine::getSlotDiffRenderers;1736, array)
#5 /srv/mediawiki/php-1.34.0-wmf.6/includes/diff/DifferenceEngine.php(1179): DifferenceEngine->getSlotDiffRenderers()
#6 /srv/mediawiki/php-1.34.0-wmf.6/extensions/MobileFrontend/includes/diff/InlineDifferenceEngine.php(202): DifferenceEngine->getDiffBodyCacheKeyParams()
#7 /srv/mediawiki/php-1.34.0-wmf.6/includes/diff/DifferenceEngine.php(1033): InlineDifferenceEngine->getDiffBodyCacheKeyParams()
#8 /srv/mediawiki/php-1.34.0-wmf.6/extensions/MobileFrontend/includes/diff/InlineDifferenceEngine.php(65): DifferenceEngine->getDiffBody()
#9 /srv/mediawiki/php-1.34.0-wmf.6/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php(156): InlineDifferenceEngine->showDiffPage()
#10 /srv/mediawiki/php-1.34.0-wmf.6/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php(128): SpecialMobileDiff->displayDiffPage()
#11 /srv/mediawiki/php-1.34.0-wmf.6/extensions/MobileFrontend/includes/specials/MobileSpecialPage.php(74): SpecialMobileDiff->executeWhenAvailable(string)
#12 /srv/mediawiki/php-1.34.0-wmf.6/includes/specialpage/SpecialPage.php(570): MobileSpecialPage->execute(string)
#13 /srv/mediawiki/php-1.34.0-wmf.6/includes/specialpage/SpecialPageFactory.php(575): SpecialPage->run(string)
#14 /srv/mediawiki/php-1.34.0-wmf.6/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#15 /srv/mediawiki/php-1.34.0-wmf.6/includes/MediaWiki.php(865): MediaWiki->performRequest()
#16 /srv/mediawiki/php-1.34.0-wmf.6/includes/MediaWiki.php(515): MediaWiki->main()
#17 /srv/mediawiki/php-1.34.0-wmf.6/index.php(42): MediaWiki->run()
#18 /srv/mediawiki/w/index.php(3): include(string)
#19 {main}

Impact

5 Exceptions in the last 12 hours.

Notes

Details

SubjectRepoBranchLines +/-
Fix Exception by forcing default diff engine and renderermediawiki/extensions/EntitySchemamaster+10 -2
Customize query in gerrit

Event Timeline

Michael created this task.May 29 2019, 8:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2019, 8:22 AM
Michael claimed this task.May 29 2019, 11:15 AM
Restricted Application added a project: User-Michael. · View Herald TranscriptMay 29 2019, 11:15 AM
Lucas_Werkmeister_WMDE subscribed.May 29 2019, 11:26 AM

MobileFrontend hooks into GetDifferenceEngine to return an InlineDifferenceEngine on Special:MobileFrontend; ContentHandler::getSlotDiffRenderer then returns a DifferenceEngineSlotDiffRenderer instead of the TextSlotDiffRenderer we expect in EntitySchemaSlotDiffRenderer:

if ( get_class( $slotDiffRenderer ) === TextSlotDiffRenderer::class ) {
	//  To keep B/C, when SlotDiffRenderer is not overridden for a given content type
	// but DifferenceEngine is, use that instead.
	$differenceEngine = $this->createDifferenceEngine( $context );
	if ( get_class( $differenceEngine ) !== DifferenceEngine::class ) {
		// TODO turn this into a deprecation warning in a later release
		LoggerFactory::getInstance( 'diff' )->info(
			'Falling back to DifferenceEngineSlotDiffRenderer', [
				'modelID' => $this->getModelID(),
				'DifferenceEngine' => get_class( $differenceEngine ),
			] );
		$slotDiffRenderer = new DifferenceEngineSlotDiffRenderer( $differenceEngine );
	}
}

Perhaps we should just instantiate a fresh TextSlotDiffRenderer ourselves if that’s what we really need.

Michael added a comment.May 29 2019, 11:28 AM

yeah, I'm just about to create a patch. We need to both create that renderer ourselves and force the default DiffEngine, because InlineDifferenceEngine doesn't expect a diff body made of table rows :/

gerritbot added a comment.May 29 2019, 11:38 AM

Change 513092 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/EntitySchema@master] Fix Exception by forcing default diff engine and renderer

https://gerrit.wikimedia.org/r/513092

gerritbot added a project: Patch-For-Review.May 29 2019, 11:38 AM
Michael added a project: MobileFrontend.May 29 2019, 11:39 AM
Michael moved this task from Incoming to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.May 29 2019, 11:43 AM
Michael edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Michael moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Krinkle moved this task from Untriaged to Sep2019/1.34.wmf.21+ on the Wikimedia-production-error board.May 29 2019, 3:44 PM
Krinkle moved this task from Sep2019/1.34.wmf.21+ to May 2019 / 1.34.wmf.5+ on the Wikimedia-production-error board.May 29 2019, 4:06 PM
pmiazga added a project: Web-Team-Backlog (Tracking).May 30 2019, 11:00 PM
gerritbot added a comment.Jun 3 2019, 11:44 AM

Change 513092 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Fix Exception by forcing default diff engine and renderer

https://gerrit.wikimedia.org/r/513092

Maintenance_bot removed a project: Patch-For-Review.Jun 3 2019, 12:10 PM
noarave moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 3 2019, 12:12 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).Jun 3 2019, 2:00 PM
Michael moved this task from 🗃️ Incoming to ✅ my work done on the User-Michael board.Jun 11 2019, 11:52 AM
WMDE-leszek closed this task as Resolved.Jun 12 2019, 8:15 AM
WMDE-leszek moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL