Page MenuHomePhabricator
Create Task
Maniphest T225451

Remove PHP_BIN from WMF CI job configuration
Closed, ResolvedPublic
Actions

Description

This predates php7.2 and Docker-based Jenkins jobs and seems unused, time to remove?

Details

SubjectRepoBranchLines +/-
zuul: remove no more used PHP_BIN parameterintegration/configmaster+0 -4
Customize query in gerrit

Event Timeline

Krinkle created this task.Jun 10 2019, 6:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2019, 6:07 PM
Krinkle added projects: Release-Engineering-Team, Continuous-Integration-Config.Jun 10 2019, 6:07 PM
Legoktm added a comment.Jun 10 2019, 6:08 PM
[13:46:07] <legoktm> I'm 99% sure its totally unused
[13:46:59] <legoktm> unless there's some legacy non-docker job lying around that's still running?
hashar added a comment.Jun 12 2019, 1:33 PM

We might still have some old legacy jobs that could still be relying on the php wrapper (the migration was/is tracked by Continuous-Integration-Infrastructure (Slipway)). It is in integration/jenkins.git in bin/php.

Maybe we can make the wrapper to log some information whenever it is being used? I guess a log file or some spam mail might work.

hashar added a project: Technical-Debt.Jun 12 2019, 1:33 PM
greg added a project: Release-Engineering-Team-TODO.Jun 21 2019, 10:31 PM
greg edited projects, added Release-Engineering-Team (CI & Testing services); removed Release-Engineering-Team.Jun 24 2019, 7:50 PM
greg moved this task from Should be empty (use Release-Engineering-Team) to Soon-ish on the Release-Engineering-Team-TODO board.Jul 6 2019, 6:04 AM
gerritbot added a comment.Dec 21 2020, 10:48 AM

Change 651163 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] zuul: remove no more used PHP_BIN parameter

https://gerrit.wikimedia.org/r/651163

gerritbot added a project: Patch-For-Review.Dec 21 2020, 10:48 AM
hashar claimed this task.Dec 21 2020, 10:49 AM

Done finally. The sole script using it was in integration/jenkins which has been archived.

hashar triaged this task as Low priority.Dec 21 2020, 10:49 AM
gerritbot added a comment.Dec 21 2020, 4:29 PM

Change 651163 merged by jenkins-bot:
[integration/config@master] zuul: remove no more used PHP_BIN parameter

https://gerrit.wikimedia.org/r/651163

Stashbot added a comment.Dec 21 2020, 4:29 PM

Mentioned in SAL (#wikimedia-releng) [2020-12-21T16:29:52Z] <James_F> Zuul: No longer set PHP_BIN parameter T225451

Jdforrester-WMF closed this task as Resolved.Dec 21 2020, 4:41 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 21 2020, 5:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits