Description
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Addshore | T208425 [EPIC] Kill the wb_terms table | |||
| Resolved | Addshore | T219303 [Checkpoint 5] Update Read Logic | |||
| Resolved | • alaa_wmde | T225603 Wire up read logic for normalized storage in Wikibase | |||
| Resolved | • alaa_wmde | T225003 Implement PropertyLabelResolver using normalized storage | |||
| Resolved | • alaa_wmde | T225626 Remove fallback to master logic from resolver | |||
| Resolved | • alaa_wmde | T225717 Implement DatabaseTermIdsResolver::resolveTermsViaJoin | |||
| Resolved | • alaa_wmde | T225718 Add TypeIdsLookup and implement it in DatabaseTypeIdsStore | |||
| Resolved | • alaa_wmde | T225818 Add type and language filtering capabilities to DatabaseTermIdsResolver::resolveTermsViaJoin | |||
| Resolved | Lucas_Werkmeister_WMDE | T225001 Implement PrefetchingTermLookup for properties using normalized storage |
Event Timeline
Change 516612 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Rename some Dispatching* services for clarification
It looks like the current BufferingTermLookup is set up in two places:
- In data-access/src/PerRepositoryServiceWiring.php, which is eventually used by MultipleRepositoryAwareWikibaseServices and used if useEntitySourceBasedFederation is false.
- In data-access/src/SingleEntitySourceServices.php, which is eventually used by MultipleEntitySourceServices and used if useEntitySourceBasedFederation is true.
I have no idea why we seem to have two completely separate federated service setups. useEntitySourceBasedFederation defaults to false, but in production is set to true for Commons and Test Wikidata, as well as any beta installation, and since production Wikidata shouldn’t use federation as far as I’m aware, I guess we’re actually using entity source-based federation everywhere? Whatever that means.
I figure we still need to wire up the new logic in both places, but this looks like something that should be cleaned up, or at least documented better…
Change 516621 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add default to ByTypeDispatchingPrefetchingTermLookup
Change 516622 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add PrefetchingPropertyTermLookup in data access
Change 516621 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add default to ByTypeDispatchingPrefetchingTermLookup
Change 516622 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add PrefetchingPropertyTermLookup in data access
Well, this also still needs to be wired up so that DataAccessSettings::useNormalizedPropertyTerms() can actually return true. I’m still working on that part, so re-claiming the task.
Change 516790 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add client setting to read from normalized terms schema
PropertyLabelResolver is actually used in client, this means it has to access db using DBAccessBase, which means that has to be pushed down to all our Database implementations too and used there instead of ILoadBalancer.
Maybe we don't need that yet. Seems like we only need to get the right LoadBalancer instance and that should be enough. Let's see
Change 517148 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/Wikibase@master] WIP. Use CachedDatabasePropertyLabelResolver depending on property terms migratin stage.
I'm talking nonsense .. of course we have to support federation if the old TermSqlIndex did
Change 517430 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/WikibaseCirrusSearch@master] Tests: Change DataAccessSettings constructor call
Change 517432 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/WikibaseMediaInfo@master] Update DataAccessSettings constructor call
Change 517430 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Tests: Change DataAccessSettings constructor call
Change 517432 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Update DataAccessSettings constructor call
Change 516790 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add client setting to read from normalized terms schema
Change 517148 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use CachedDatabasePropertyLabelResolver depending on property terms migratin stage.
Change 516612 abandoned by Lucas Werkmeister (WMDE):
[mediawiki/extensions/Wikibase@master] Rename some Dispatching* services for clarification
Reason:
All the classes which this change renamed to ByRepository* are gone from master by now.