Page MenuHomePhabricator
Create Task
Maniphest T225345

Test read logic of new terms store on test node
Closed, ResolvedPublic
Actions

Description

Wiating on T225603

How to test

  1. Make sure you have wikibase extension tree on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/517148
  1. You should have the following in LocalSettings.php:
$wgWBRepoSettings['tmpPropertyTermsMigrationStage'] = MIGRATION_WRITE_NEW;
$wgWBClientSettings['tmpPropertyTermsMigrationStage'] = MIGRATION_WRITE_NEW;

// for convineince during the test, bypass caching
$wgMainCacheType = CACHE_NONE;
$wgParserCacheType = CACHE_NONE; # optional
$wgMessageCacheType = CACHE_NONE; # optional
  1. Create a property, or use an existing property
  1. Hide all terms of that property from wb_terms table (you can use sql repl php /var/www/html/maintenance/sql.php to execute sql):
UPDATE wb_terms SET term_full_entity_id = "hidden_Pxxx" WHERE term_full_entity_id = "Pxxx"; -- replace Pxxx with the property full id
  1. go over the use cases.. properties should render properly.

Use Cases to test

  • Rendering property labels in statements blocks (uses PropertyLabelResolver).
  • Rendering property labels & descriptions in search results when searching for a property when adding a statement (users PrefetchingTermLookup).
  • Rendering property labels on Special:AllPages?namespace=122 (or 120 depending on wiki configuration)
  • Rendering property labels on Special:RecentChanges
  • ...

Related Objects
Search...

Event Timeline

• alaa_wmde created this task.Jun 8 2019, 10:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2019, 10:51 AM
• alaa_wmde updated the task description. (Show Details)Jun 8 2019, 10:53 AM
• alaa_wmde claimed this task.Jun 17 2019, 10:31 AM
• alaa_wmde moved this task from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.
• alaa_wmde added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
• alaa_wmde renamed this task from Test read logic on test node to Test read logic of new terms store on test node.Jun 17 2019, 10:37 AM
• alaa_wmde updated the task description. (Show Details)
• alaa_wmde moved this task from In Progress to Ready to go [prioritized] on the Wikidata wb_terms Trailblazing board.Jun 18 2019, 11:26 AM
• alaa_wmde moved this task from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.Jun 19 2019, 8:26 PM
• alaa_wmde updated the task description. (Show Details)Jun 19 2019, 9:00 PM
• alaa_wmde updated the task description. (Show Details)
• alaa_wmde added a comment.Jun 19 2019, 9:04 PM

I tested those cases (✅ works, 🔴 broken).

✅ Rendering property labels in statements blocks (uses PropertyLabelResolver).
✅ Rendering property labels & descriptions in search results when searching for a property when adding a statement (users PrefetchingTermLookup).

• alaa_wmde added subscribers: Lucas_Werkmeister_WMDE, Ladsgroup, Addshore, hoo.EditedJun 19 2019, 9:07 PM

@hoo @Lucas_Werkmeister_WMDE @Addshore @Ladsgroup any other use cases to check?

the mentioned two cases in task description already cover the two interfaces that are used to read from terms store, and when migration stage is WRITE_NEW, our implementations for the new store should be in use. There could be some critical use-cases that need to be tested (perhaps with caching enabled too) as well just for increased safety and confidence.

• alaa_wmde updated the task description. (Show Details)Jun 19 2019, 9:09 PM
• alaa_wmde updated the task description. (Show Details)
• alaa_wmde updated the task description. (Show Details)
• alaa_wmde updated the task description. (Show Details)Jun 19 2019, 9:15 PM
• alaa_wmde updated the task description. (Show Details)
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 20 2019, 11:27 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 20 2019, 11:29 AM
Lucas_Werkmeister_WMDE added a comment.Jun 20 2019, 11:32 AM

✅ Rendering property labels in statements blocks (uses PropertyLabelResolver).

I don’t think that uses PropertyLabelResolver – PropertyLabelResolver turns labels into property IDs, when rendering statements we turn property IDs into labels. As far as I’m aware, PropertyLabelResolver is only used for the WikibaseClient Lua and parser functions. (As long as the repo wikis has WikibaseClient enabled, you don’t need a separate wiki to test this.)

• alaa_wmde moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 20 2019, 3:15 PM
• alaa_wmde added a comment.EditedJun 20 2019, 3:21 PM
In T225345#5270864, @Lucas_Werkmeister_WMDE wrote:

✅ Rendering property labels in statements blocks (uses PropertyLabelResolver).

I don’t think that uses PropertyLabelResolver – PropertyLabelResolver turns labels into property IDs, when rendering statements we turn property IDs into labels. As far as I’m aware, PropertyLabelResolver is only used for the WikibaseClient Lua and parser functions. (As long as the repo wikis has WikibaseClient enabled, you don’t need a separate wiki to test this.)

Thanks for the adding more cases @Lucas_Werkmeister_WMDE

True. I must have got confused while trying to navigate through references in the code to understand where those are used .. so then it must be used the PrefetchingTermLookup?)

• alaa_wmde added a comment.Jun 20 2019, 3:49 PM

Test run: I tested those cases (✅ works, 🔴 broken).

✅ Rendering property labels in statements blocks
✅ Rendering property labels & descriptions in search results when searching for a property when adding a statement
✅ Rendering property labels on Special:AllPages?namespace=122
✅ Rendering property labels on Special:RecentChanges

• alaa_wmde removed • alaa_wmde as the assignee of this task.EditedJun 21 2019, 7:33 AM
• alaa_wmde moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Moving back to To Do to be picked up again once T225603 is done and all patched are merged, so that this is tested on master branch.

• alaa_wmde moved this task from To Do (prioritised from top to bottom) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 21 2019, 7:38 AM
• alaa_wmde updated the task description. (Show Details)
noarave subscribed.Jul 1 2019, 9:17 AM

@alaa_wmde this can go to the To Do column again, can't it?

• alaa_wmde added a comment.Oct 1 2019, 2:30 PM

This can be tested again. Maybe we want to switch test wikidata to read properties from new store

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 1 2019, 2:30 PM
• alaa_wmde edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Oct 1 2019, 2:30 PM
Addshore added a parent task: T208425: [EPIC] Kill the wb_terms table.Oct 31 2019, 7:34 AM
Addshore closed this task as Resolved.EditedNov 19 2019, 12:52 PM
Addshore claimed this task.

Per chatting with @Ladsgroup

The read part is in production for properties and it works just fine
There are issues, and they are all already known (via other tickets)

Restricted Application added a project: User-Addshore. · View Herald TranscriptNov 19 2019, 12:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL