Page MenuHomePhabricator

Special:Manage_Two-factor_authentication looks odd
Closed, ResolvedPublic

Description

On Special:Manage_Two-factor_authentication on my dev wiki... Looks odd, presumably because the only available method is enabled?

There should be some message under "available methods" (potentially depending if there are any actual methods - "all enabled auth methods are enabled" or "no more auth methods can be enabled) or else not show the section with no other methods... Basically, the "available methods" heading shouldn't have nothing under it

Event Timeline

Reedy created this task.Jun 18 2019, 8:43 PM
Reedy updated the task description. (Show Details)Jun 18 2019, 8:46 PM
Reedy updated the task description. (Show Details)Jun 18 2019, 9:51 PM
Reedy removed ItSpiderman as the assignee of this task.Jul 4 2019, 12:09 AM

This is fixed in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OATHAuth/+/499183/30/src/Special/OATHManage.php L124
Whole section is not added if its empty.
It could have regressed in later commits, i will pay attention to this as commits get merged

The whole UI has a lot of room to improve, so all suggestions on how to make it better are welcome

Reedy closed this task as Resolved.Jul 4 2019, 6:53 PM
Reedy assigned this task to ItSpiderman.

This is fixed in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OATHAuth/+/499183/30/src/Special/OATHManage.php L124
Whole section is not added if its empty.
It could have regressed in later commits, i will pay attention to this as commits get merged
The whole UI has a lot of room to improve, so all suggestions on how to make it better are welcome

Confirmed and merged