Page MenuHomePhabricator
Create Task
Maniphest T226053

Special:Manage_Two-factor_authentication looks odd
Closed, ResolvedPublic
Actions

Description

On Special:Manage_Two-factor_authentication on my dev wiki... Looks odd, presumably because the only available method is enabled?

Screenshot 2019-06-18 at 21.42.04.png (734×840 px, 66 KB)

Screenshot 2019-06-18 at 21.45.14.png (568×774 px, 53 KB)

There should be some message under "available methods" (potentially depending if there are any actual methods - "all enabled auth methods are enabled" or "no more auth methods can be enabled) or else not show the section with no other methods... Basically, the "available methods" heading shouldn't have nothing under it

Related Objects
Search...

Event Timeline

Reedy created this task.Jun 18 2019, 8:43 PM
Reedy updated the task description. (Show Details)Jun 18 2019, 8:46 PM
Reedy updated the task description. (Show Details)Jun 18 2019, 9:51 PM
Reedy removed ItSpiderman as the assignee of this task.Jul 4 2019, 12:09 AM
ItSpiderman added a comment.Jul 4 2019, 6:38 AM

This is fixed in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OATHAuth/+/499183/30/src/Special/OATHManage.php L124
Whole section is not added if its empty.
It could have regressed in later commits, i will pay attention to this as commits get merged

The whole UI has a lot of room to improve, so all suggestions on how to make it better are welcome

Osnard added a comment.Jul 4 2019, 7:27 AM

Belongs to T218214

Reedy closed this task as Resolved.Jul 4 2019, 6:53 PM
Reedy assigned this task to ItSpiderman.
In T226053#5305877, @ItSpiderman wrote:

This is fixed in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OATHAuth/+/499183/30/src/Special/OATHManage.php L124
Whole section is not added if its empty.
It could have regressed in later commits, i will pay attention to this as commits get merged

The whole UI has a lot of room to improve, so all suggestions on how to make it better are welcome

Confirmed and merged

WDoranWMF moved this task from Contractor - Doing to S&F Workboard on the Platform Team Workboards board.Jul 5 2019, 5:09 PM
WDoranWMF edited projects, added Platform Team Workboards (S&F Workboard); removed Platform Team Workboards (Contractor - Doing).
WDoranWMF moved this task from Backlog to Done on the Platform Team Workboards (S&F Workboard) board.
CCicalese_WMF edited projects, added Core Platform Team Initiatives (Two-Factor Authentication (TEC1)); removed Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)).Jul 27 2019, 4:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits