Page MenuHomePhabricator
Create Task
Maniphest T226374

Impossible to copypaste a specific template across windows
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. Open a sample page with "Portály" template on cswiki (eg. Fritz Wolfgang London).
  2. Select the template at the bottom of the page and copy it (Ctrl+C).
  3. Open a random page for editing.
  4. Paste the template (Ctrl+V).

Actual Results:

  • Nothing is pasted, possibly an empty line.

Expected Results:

  • The template is pasted with all its parameters.

This issue is specific to this template.

Details

SubjectRepoBranchLines +/-
ve.dm.MWTransclusionNode: Protect <style> nodes too when copyingmediawiki/extensions/VisualEditormaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

matej_suchanek created this task.Jun 24 2019, 9:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2019, 9:44 AM
Vojtech.Vesely subscribed.Jun 25 2019, 5:07 AM
matmarex subscribed.Jul 16 2019, 8:48 PM

This happens because the template HTML starts with a <style> node (generated by TemplateStyles). When copying a template, VisualEditor stores some metadata on the first node (e.g. the name of the template). But when pasting, we remove all <style> nodes (due to T185532), which means that this node is lost and as a result we lose the entire template.

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Jul 16 2019, 8:48 PM
gerritbot added a comment.Jul 16 2019, 8:51 PM

Change 523802 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.dm.MWTransclusionNode: Protect <style> nodes too when copying

https://gerrit.wikimedia.org/r/523802

gerritbot added a project: Patch-For-Review.Jul 16 2019, 8:51 PM
gerritbot added a comment.Jul 16 2019, 10:21 PM

Change 523802 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.dm.MWTransclusionNode: Protect <style> nodes too when copying

https://gerrit.wikimedia.org/r/523802

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 16 2019, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 16 2019, 11:10 PM
matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.Jul 17 2019, 5:20 PM
JTannerWMF added a project: Editing QA.Jul 24 2019, 2:59 PM
matmarex moved this task from Inbox to Low Priority on the Editing QA board.Aug 9 2019, 4:56 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Sep 6 2019, 10:40 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
ppelberg closed this task as Resolved.Sep 20 2019, 11:05 PM
ppelberg claimed this task.
Vojtech.Vesely awarded a token.Sep 20 2019, 11:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL